Skip to content

Add FieldsContainer.animate() #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 96 commits into from
Sep 22, 2022
Merged

Add FieldsContainer.animate() #432

merged 96 commits into from
Sep 22, 2022

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Aug 29, 2022 •
edited
Loading

Resolves #405

  • Implement helper
  • Tests
  • Example
  • GIFs are included in the HTML doc correctly

PProfizi added 30 commits June 15, 2022 14:11
@PProfizi
WIP
8e9e550
@PProfizi
Fixed MeshedRegion.plot(warped)
992777a
@PProfizi
Clean example
e7e017c
@PProfizi
Finish adding scale factor text
7086bff
@PProfizi
Add show_axes=True as default when plotting
436687e
@PProfizi
Forcing protobuf to less than 4.*
4e94dff
@PProfizi
Fix error when warping_field is None for MeshesContainer.plot
9975b67
@PProfizi
Refactor name of argument as "warp_by"
b996e12 
Update docstrings
@PProfizi
Fix coordinates as optional in _as_vtk
9e65a1e
@PProfizi
Refactor the first test with more pythonic and newer API calls.
8723bc2
@PProfizi
Renamed the mesh warp method to scale_coordinates_by_result
1a15a2b
@PProfizi
Start adding animation methods to the fields_container
87d8f91
@PProfizi
Add add_fields_container to DpfPlotter
63e73bd
@PProfizi
Add docstring to DpfPlotter.add_fields_container
e218dd2
@PProfizi
DpfPlotter.add_fields_container should actually only be a helper to a…
3abd4cd 
…dd several fields at once.
@PProfizi
Create PyVistaImportError in vtk_helper.py
5d7fcca
@PProfizi
Use PyVistaImportError in _PyVistaPlotter and restrain the import che…
8028b5c 
…ck to the __init__.
@PProfizi
Create FieldsContainer.animate with expected calls to new Animator class
76ab8a5
@PProfizi
Create the Animator class as well as the animator factory and the _Py…
33ce950 
…VistaAnimator backend.
@PProfizi
WIP
6079ce2
@PProfizi
WIP
07f0722
@PProfizi
WIP
11f4af0
@PProfizi
Merge branch 'master' into feat/animations
82abfb5 
# Conflicts:
#	ansys/dpf/core/field.py
#	ansys/dpf/core/meshed_region.py
#	ansys/dpf/core/meshes_container.py
#	ansys/dpf/core/plotter.py
#	ansys/dpf/core/vtk_helper.py
#	examples/05-plotting/05-plot_on_warped_mesh.py
#	tests/test_plotter.py
@PProfizi
Set _set_scalar_bar_title as static
95fcf70
@PProfizi
Use case # 1 working
9bc5b89
@PProfizi
Add TODO to FieldsContainer.animate
ab7ab86
@PProfizi
WIP
f623f5e
@PProfizi
Merge branch 'master' into feat/animations
290246d 
# Conflicts:
#	ansys/dpf/core/fields_container.py
@PProfizi
WIP
1d6725a
@PProfizi
WIP
f3e95f7
@PProfizi
Finish removing support for Field or FieldsContainer scale_factor
f9d7e6b
@PProfizi
Improve coverage of scale_factor type
303408e
@PProfizi
Do not cover mp4 creation.
b6cec22
@PProfizi
Test animation with cpos
da54b4c
@PProfizi
Cannot easily test animation cancellation.
a84bc49
@PProfizi
test raise scale_factor field or FieldsContainer
060a4c7
@PProfizi
Add opengl fix.
6d710f6
@PProfizi
Add test_fields_container_get_time_scoping
a9b2c77
@PProfizi
Test animation of one-component fields
b00dd9d
@PProfizi
Add testing of deform_by result and deform_by operator
e215b17
@PProfizi
Test error when deform_by fields_container is not scoped on the same …
5a1fafa 
…number of frequencies
@PProfizi
Remove "through" argument.
6935b72
@PProfizi
Fix code quality
7026071
@PProfizi
Add test_animator_animate_fields_container_scale_factor_raise_list_len
7e247e1
@PProfizi
Add test_animator_animate_fields_container_deform_by_false
2fcaf00
@PProfizi
Select animation in doc
8e69966
@PProfizi
Select animation in doc
d05ed31
@PProfizi
Component count and norm is done in _PyVistaPlotter.add_field
0ea6f34
@PProfizi
Remove "through" from dosctring
3048988
@PProfizi PProfizi linked an issue Sep 21, 2022 that may be closed by this pull request
Create animations of results in PyDPF #231
Closed
@PProfizi PProfizi removed a link to an issue Sep 21, 2022
Create animations of results in PyDPF #231
Closed
@PProfizi PProfizi linked an issue Sep 21, 2022 that may be closed by this pull request
Create animations of results in PyDPF #231
Closed
@PProfizi PProfizi merged commit 7c960e9 into master Sep 22, 2022
@PProfizi PProfizi deleted the feat/animations branch September 22, 2022 15:50
@PProfizi PProfizi restored the feat/animations branch October 18, 2022 11:09
@PProfizi PProfizi deleted the feat/animations branch October 20, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbellot000 cbellot000 cbellot000 approved these changes

Assignees

@PProfizi PProfizi

Labels

enhancement New feature or request

Projects

None yet

Milestone

v0.6.1

Development

Successfully merging this pull request may close these issues.

Add animations to Core Create animations of results in PyDPF

2 participants

@PProfizi @cbellot000