Skip to content

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented May 12, 2025

The PyDPF-Core CI runs PyDPF-Post tests for information purposes thanks to its pydpf-post.yml workflow.
This PR makes sure that the workflow is always reported as successful to not stop people from merging, while still reporting errors for PyDPF-Post tests as comments in the PR if any.
This is most useful for server-sync PRs.

@PProfizi PProfizi added the CI/CD Related to CI/CD label May 12, 2025
@PProfizi PProfizi self-assigned this May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.77%. Comparing base (f55da78) to head (a2d1f30).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   83.84%   83.77%   -0.08%     
==========================================
  Files          90       90              
  Lines       10396    10396              
==========================================
- Hits         8717     8709       -8     
- Misses       1679     1687       +8     

Job-level continue-on-error still reports workflow as having failed.
Step-level must be used for the overall workflow to report success.
@PProfizi
Copy link
Contributor Author

Here is a CI run on the daily standalone (where pydpf-post tests fail), still reporting PyDPF-Post workflow as passing https://github.com/ansys/pydpf-core/actions/runs/14966392212

@PProfizi PProfizi requested review from moe-ad and rafacanton May 12, 2025 07:51
@PProfizi PProfizi marked this pull request as ready for review May 12, 2025 07:51
@PProfizi
Copy link
Contributor Author

PProfizi commented May 12, 2025

@rafacanton the continue-on-error already makes the workflow go green despite PyDPF-Post tests failing as you can see in the CI in the previous comment.
I just added use of a continue-on-error-comment action, which we can test by merging this and then updating the daily server-sync PR currently failing, to see if comments do appear.
In any case it will have solved the initial issue.

@PProfizi PProfizi enabled auto-merge (squash) May 12, 2025 07:55
@PProfizi PProfizi disabled auto-merge May 12, 2025 08:04
@PProfizi PProfizi merged commit 8e7e113 into master May 12, 2025
59 of 65 checks passed
@PProfizi PProfizi deleted the ci/pydpf-post_continue-on-error branch May 12, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants