Skip to content

Conversation

@PProfizi
Copy link
Contributor

Detect case of aligned point and line from which we cannot define a plane.
Update testing accordingly.
This was somehow working before due to pyvista accepting NaN in transform matrices, which is not the case starting with pyvista==0.45.0.

@PProfizi PProfizi added the bug Something isn't working label Apr 30, 2025
@PProfizi PProfizi added this to the 0.13.7 milestone Apr 30, 2025
@PProfizi PProfizi requested a review from rafacanton April 30, 2025 12:00
@PProfizi PProfizi self-assigned this Apr 30, 2025
@PProfizi PProfizi requested a review from moe-ad April 30, 2025 12:00
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (e8f6fc5) to head (8e4dc48).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2250   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files          90       90           
  Lines       10308    10309    +1     
=======================================
+ Hits         8653     8654    +1     
  Misses       1655     1655           

@PProfizi PProfizi merged commit c5a7f03 into master Apr 30, 2025
41 checks passed
@PProfizi PProfizi deleted the fix/geometry_factory_plane_from_aligned_point_and_line branch April 30, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants