Skip to content

Adapt to Units improvement and Temperature Difference handling #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 10, 2025
Merged

Adapt to Units improvement and Temperature Difference handling #2073

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f496b06
Adapt units symbol for temperature difference
TheoMeunierAnsys Feb 10, 2025
aacd33b
Merge branch 'master' of https://github.com/ansys/pydpf-core into tme…
TheoMeunierAnsys Feb 11, 2025
9214732
Adapt unit test for unit system name
TheoMeunierAnsys Feb 11, 2025
3ca30c3
Handle retro compatibility
TheoMeunierAnsys Feb 11, 2025
4755735
Merge branch 'master' of https://github.com/ansys/pydpf-core into tme…
TheoMeunierAnsys Mar 10, 2025
eb52b11
Fix reference
TheoMeunierAnsys Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions tests/test_resultinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_7_0,
SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_7_1,
SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_8_0,
SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_10_0,
)

if SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_5_0:
Expand Down Expand Up @@ -117,7 +118,19 @@ def test_repr_available_results_list(model):
)
def test_print_available_result_with_qualifiers(cfx_heating_coil, server_type):
model = Model(cfx_heating_coil(server=server_type), server=server_type)
ref = """DPF Result
if SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_10_0:
ref = """DPF Result
----------
specific_heat
Operator name: "CP"
Number of components: 1
Dimensionality: scalar
Homogeneity: specific_heat
Units: J/kg*dK^-1
Location: Nodal
Available qualifier labels:""" # noqa: E501
else:
ref = """DPF Result
----------
specific_heat
Operator name: "CP"
Expand Down Expand Up @@ -148,8 +161,29 @@ def test_print_available_result_with_qualifiers(cfx_heating_coil, server_type):
)
def test_print_result_info_with_qualifiers(cfx_heating_coil, server_type):
model = Model(cfx_heating_coil(server=server_type), server=server_type)
ref = """Static analysis
Unit system: SI: m, kg, N, s, V, A, K
if SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_10_0:
ref = """Static analysis
Unit system: Custom: m, kg, N, s, V, A, K
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheoMeunierAnsys I' sorry I do not see the difference with the initial reference

Physics Type: Fluid
Available results:
- specific_heat: Nodal Specific Heat
- epsilon: Nodal Epsilon
- enthalpy: Nodal Enthalpy
- turbulent_kinetic_energy: Nodal Turbulent Kinetic Energy
- thermal_conductivity: Nodal Thermal Conductivity
- dynamic_viscosity: Nodal Dynamic Viscosity
- turbulent_viscosity: Nodal Turbulent Viscosity
- static_pressure: Nodal Static Pressure
- total_pressure: Nodal Total Pressure
- density: Nodal Density
- entropy: Nodal Entropy
- temperature: Nodal Temperature
- total_temperature: Nodal Total Temperature
- velocity: Nodal Velocity
Available qualifier labels:""" # noqa
else:
ref = """Static analysis
Unit system: Custom: m, kg, N, s, V, A, K
Physics Type: Fluid
Available results:
- specific_heat: Nodal Specific Heat
Expand Down
Loading