Skip to content

Conversation

@luisaFelixSalles
Copy link
Contributor

@luisaFelixSalles luisaFelixSalles commented Sep 30, 2024

This PR brings a new proposition for the tutorials section layout

  • Changes in the tutorials categories
  • Add the " Enriching DPF capabilities" section as a tutorial topic

Preview on how it renders:

image

image

@luisaFelixSalles luisaFelixSalles self-assigned this Sep 30, 2024
@luisaFelixSalles luisaFelixSalles added the documentation Improvements or additions to documentation label Sep 30, 2024
Comment on lines +23 to +24
There are four main steps to transform simulation data into output data that can
be used to visualize and analyze simulation results:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed further. I think it would be better to mention different categories of actions you can perform with PyDPF-Core. The end-goal of using PyDPF-Core is not necessarily to visualize and analyze.
Maybe something along the lines of: "There are different kind of actions you can perform: from extracting result from result files, to visualization of extracted data, to filtering, transformation of the data, and much more."


**Load data**

.. topic:: Importing and opening results files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. topic:: Importing and opening results files
.. topic:: Extract data from result files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if using "extract " here is a great idea. Because in the other section we talk about extracting (like if I want to have a displacement result). So here is it actually extract a result?

.. grid:: 3

Fields
.. grid-item-card:: I have one file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. grid-item-card:: I have one file
.. grid-item-card:: Extract data from a single file

:text-align: center

PropertyField
Import and open a single result file with PyDPF-Core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Import and open a single result file with PyDPF-Core.
Extract data from a single result file with PyDPF-Core.

Import and open a single result file with PyDPF-Core.

StringField
.. grid-item-card:: I have more than one file
Copy link
Contributor

@PProfizi PProfizi Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. grid-item-card:: I have more than one file
.. grid-item-card:: Extract data from distributed result files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the idea would be to also add a tutorial for:

  • when you have accessory files
  • when you have upstream result files
  • and so on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If you have more than one file the tutorial will talk about these cases

Comment on lines +21 to +22
There are four main steps to transform simulation data into output data that can
be used to visualize and analyze simulation results:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are four main steps to transform simulation data into output data that can
be used to visualize and analyze simulation results:
There are different kind of actions you can perform with PyDPF-Core: from extracting result from result files, to visualization of extracted data, to filtering, transformation of the data, and much more.
Nevertheless, we can summarize in four main steps the process of transforming simulation data into post-processed output data :

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (doc/general-layout@2d4f565). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             doc/general-layout    #1779   +/-   ##
=====================================================
  Coverage                      ?   85.78%           
=====================================================
  Files                         ?       83           
  Lines                         ?     9948           
  Branches                      ?        0           
=====================================================
  Hits                          ?     8534           
  Misses                        ?     1414           
  Partials                      ?        0           

@PProfizi PProfizi deleted the doc/tutorials-new-layout branch November 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants