Associate the mesh to the Nodes.coordinates field #1473
Conversation
…ng and further handling by Post Signed-off-by: paul.profizi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1473 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 82 82
Lines 9631 9633 +2
=======================================
+ Hits 8361 8363 +2
Misses 1270 1270 |
Signed-off-by: paul.profizi <[email protected]>
Wiz Scan Summary
|
| """ | ||
| return self._get_coordinates_field() | ||
| cf = self._get_coordinates_field() | ||
| cf.meshed_region = self._mesh |
There was a problem hiding this comment.
Doesn't this create a sort of circular dependency? The mesh has a field inside (the coordinate field), that has the mesh as its support, that in turn has a coordinate field.... and so on
There was a problem hiding this comment.
@rafacanton Notice that here I only do that when returning a "standalone" Field. Its associated mesh will indeed have a coordinates PropertyField, but that one will not have an associated mesh until we explicitly request it on its own
There was a problem hiding this comment.
@PProfizi Yes, I understand that this association will not happen until this method is called. I cannot imagine of any potential downside that this can have down the stream (after having created the circ dep). @cbellot000 can you imagine of any? For example, what if you then add a new node to the mesh? This pushes back an id and 3 doubles in the coord field. Is there any problem in doing this with a field that has as a support the same mesh where this field is stored?
There was a problem hiding this comment.
Hi @rafacanton , Hi @cbellot000 ,
If we cannot think of a way this may break something, we might as well merge it.
It is mandatory for several purposes when handling a PropertyField.
This made the coordinates field unavailable for plotting and further handling by Post