Fix InProcess path update #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/ansys/pydpf-core into maint/update_code_for_242_rcs_242_after_on_master
This reverts commit ded2061.
This reverts commit 77455f5.
This reverts commit 4d56b19.
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
This reverts commit 777909b.
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
This reverts commit 777909b.
… fix/inprocess_path_update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1449 +/- ##
==========================================
- Coverage 86.71% 86.68% -0.03%
==========================================
Files 81 81
Lines 9546 9548 +2
==========================================
- Hits 8278 8277 -1
- Misses 1268 1271 +3 |
…" branch Signed-off-by: paul.profizi <[email protected]> Get the right standalone suffix when PR on a "maint/update_code_for_*" branch Signed-off-by: paul.profizi <[email protected]>
PProfizi
force-pushed
the
fix/inprocess_path_update
branch
from
5f8e252 to
b9324d2
Compare
Base automatically changed from
maint/update_code_for_242_rcs_242_after_on_master
to
master
March 4, 2024 08:48
Signed-off-by: paul.profizi <[email protected]>
rafacanton
approved these changes
Mar 4, 2024
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, since moving on from
2024.2.pre0, we noticed that starting aGrpcServerafter anInProcessserver made operations using theCadoefail on theInProcessserver.This is due to changes made server-side to the
PATHenvironment variable, which is not picked-up by Python'sos.environdue to it being a static map built when importing theoslibrary for the first time. Only modification viaosis picked-up byos.environ.The problem arises because the instantiation of a
GrpcServermanipulates thePATH, however the "starting"PATHis not up-to-date.Conclusion: after starting an
InProcessserver, we have to manually update thePATHvariable known to Python inos.environ.See here for passing tests on Windows for 3.9.