Skip to content

Conversation

@PProfizi
Copy link
Contributor

instead of creating a new "plane" argument

@PProfizi PProfizi added the bug Something isn't working label Jul 31, 2023
@PProfizi PProfizi requested a review from anslpa July 31, 2023 13:57
@PProfizi PProfizi self-assigned this Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1084 (386f7f4) into master (63d9bf5) will increase coverage by 0.04%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   87.56%   87.61%   +0.04%     
==========================================
  Files          80       81       +1     
  Lines        9078     9178     +100     
==========================================
+ Hits         7949     8041      +92     
- Misses       1129     1137       +8     

@PProfizi PProfizi added this to the v0.9.0 milestone Jul 31, 2023
@PProfizi PProfizi requested a review from rafacanton August 1, 2023 08:23
Copy link
Contributor

@anslpa anslpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion!

@PProfizi PProfizi merged commit febf38f into master Aug 1, 2023
@PProfizi PProfizi deleted the fix/use_cpos_instead_of_new_plane_argument branch August 1, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants