Helpers: compute streamlines #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Remaining is the implementation.
… all examples to use "compute_streamline"
…into helpers/compute_streamlines
Codecov Report
@@ Coverage Diff @@
## plot/streamlines #1062 +/- ##
====================================================
- Coverage 87.95% 87.82% -0.13%
====================================================
Files 78 80 +2
Lines 9016 9038 +22
====================================================
+ Hits 7930 7938 +8
- Misses 1086 1100 +14 |
anslpa
added a commit
that referenced
this pull request
Jul 26, 2023
* Add "add_streamlines" methods * Add plot streamlines example * field as field only (no list) * Use download files * Correctly compute streamlines field name * Docstring added * filter kwargs * Add time report (to revert) * Update example with better values for elbow * Revert "Add time report (to revert)" This reverts commit 55f8ae1. * Add permissive * Surface streamline example * show_plane argument * Style check * Style check * show_plane replaced by plane * Update docstring plane * Update examples/06-plotting/08_plot_3d_streamlines.py Co-authored-by: JennaPaikowsky <[email protected]> * Update examples/06-plotting/08_plot_3d_streamlines.py Co-authored-by: JennaPaikowsky <[email protected]> * Update examples/06-plotting/08_plot_3d_streamlines.py Co-authored-by: JennaPaikowsky <[email protected]> * Update examples/06-plotting/08_plot_3d_streamlines.py Co-authored-by: JennaPaikowsky <[email protected]> * Update examples/06-plotting/08_plot_3d_streamlines.py Co-authored-by: JennaPaikowsky <[email protected]> * Update examples/06-plotting/09_plot_surface_streamlines.py Co-authored-by: JennaPaikowsky <[email protected]> * Update examples/06-plotting/09_plot_surface_streamlines.py Co-authored-by: JennaPaikowsky <[email protected]> * Update src/ansys/dpf/core/plotter.py Co-authored-by: JennaPaikowsky <[email protected]> * Remove * style check * Helpers: compute streamlines (#1062) * Add helpers * enhance descr * Prepare "compute_streamlines" method and adapt the examples/plot code. Remaining is the implementation. * try pyvista import * protoype working return pv.DataSets and pv.PolyData * fix raising * create helpers module as folder * update src * use translation methods * typo * first tries for creating pvDataSet * Add streamlines and streamlinessource classes * Remove meshed_region and field attributes from add_streamline, update all examples to use "compute_streamline" * replace computed_streamlines and computed_source * update docstring * update docstring and fix computed_streamlines * style check * style check * use pv_data_set * Fix doc * 12 to 13 (examples folder) * Streamlines: add base class for Streamlines and StreamlinesSource objects (#1070) * Implement base class for streamlines object, to prepare the conversion of the _pv_data_set to the _fc * fix faces * style check * style check * style check * Update examples/13-streamlines/README.txt Co-authored-by: Paul Profizi <[email protected]> * fix comment * Set permissive default value to True * Update max_time --------- Co-authored-by: JennaPaikowsky <[email protected]> Co-authored-by: Paul Profizi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to add a "compute_streamline" step to access a Streamlines object before plotting it.
It create an "helpers" module in ansys.dpf.coren contaiing a streamlines module.