Skip to content

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jul 6, 2023

Noticed failures on result query for certain results due to a badly generated Model.results Results object, becoming a CommonResults
Only for CLayer gRPC

@PProfizi PProfizi added the bug Something isn't working label Jul 6, 2023
@PProfizi PProfizi requested a review from rafacanton July 6, 2023 12:11
@PProfizi PProfizi self-assigned this Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1020 (a941506) into master (e37485e) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
+ Coverage   88.54%   88.63%   +0.09%     
==========================================
  Files          77       77              
  Lines        8727     8728       +1     
==========================================
+ Hits         7727     7736       +9     
+ Misses       1000      992       -8     

@PProfizi PProfizi added this to the v0.9.0 milestone Jul 10, 2023
@PProfizi PProfizi merged commit b2a81ff into master Jul 13, 2023
@PProfizi PProfizi deleted the fix/cff_results branch July 13, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants