Skip to content
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
964bbcb
Initial edits, mostly to RST files and some examples
PipKat Apr 10, 2025
285f649
Minor edit to an example file
PipKat Apr 10, 2025
0faedf5
dummy commit
mhoeijm Apr 11, 2025
ebaeefc
dummy commit
mhoeijm Apr 11, 2025
7597df2
chore: adding changelog file 1043.documentation.md [dependabot-skip]
pyansys-ci-bot Apr 11, 2025
90b435f
Remaining example files
PipKat Apr 11, 2025
f5ab60f
fix: double quotes
jorgepiloto Apr 14, 2025
d34d917
fix: syntax
jorgepiloto Apr 14, 2025
2d8e9a7
fix: accept words
jorgepiloto Apr 14, 2025
547edc3
Merge branch 'main' into docs/overall_doc_review
jorgepiloto Apr 14, 2025
5211562
fix: syntax
jorgepiloto Apr 14, 2025
360c63c
fix: ignore
jorgepiloto Apr 14, 2025
c814879
Merge branch 'main' into docs/overall_doc_review
PipKat Apr 14, 2025
46675cd
Minor edits based on skimming HTML artifact
PipKat Apr 14, 2025
0ca780e
Edits to some API reference PY files
PipKat Apr 14, 2025
315af53
fix: version in fragment
jorgepiloto Apr 15, 2025
70e371f
fix: minor typos
jorgepiloto Apr 15, 2025
4d2e021
doc: update supported LS-DYNA version and link
mhoeijm Apr 15, 2025
0825629
Merge branch 'docs/overall_doc_review' of https://github.com/ansys/py…
mhoeijm Apr 15, 2025
dea37d3
doc: fix link
mhoeijm Apr 15, 2025
63f6f03
Edits to remaining PY files
PipKat Apr 15, 2025
3ef07a5
Merge branch 'docs/overall_doc_review' of https://github.com/ansys/py…
PipKat Apr 15, 2025
7892d8f
Edits to API Reference API files
PipKat Apr 15, 2025
52eea36
Match misspelling, changing from 'create_element_solid_keyword' to cr…
PipKat Apr 15, 2025
a65a081
refactor: fix method name
mhoeijm Apr 16, 2025
721482f
refactor: remove references to master/slave
mhoeijm Apr 16, 2025
3be6f1d
Merge branch 'docs/overall_doc_review' of https://github.com/ansys/py…
mhoeijm Apr 16, 2025
aabbabf
Merge branch 'main' into docs/overall_doc_review
mhoeijm Apr 16, 2025
d51155c
Merge branch 'main' into docs/overall_doc_review
mhoeijm Apr 16, 2025
592dce5
Update src/ansys/health/heart/simulator.py
mhoeijm Apr 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/changelog/1018.miscellaneous.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
standardize type hints for pre, post and utils subpackages
standardize type hints for ``pre``, ``post``, and ``utils`` subpackages
2 changes: 1 addition & 1 deletion doc/source/changelog/1032.fixed.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
remove wheelhosue from doc/source/_static dir
remove wheelhouse from doc/source/_static dir
2 changes: 1 addition & 1 deletion doc/source/changelog/1033.maintenance.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bump version to 0.12dev0
bump version to 0.12.dev0
1 change: 1 addition & 0 deletions doc/source/changelog/1043.documentation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
overall review
133 changes: 66 additions & 67 deletions doc/source/contribute/developer.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Contributing as a developer
###########################
Contribute as a developer
#########################

.. grid:: 1 2 3 3

Expand All @@ -8,14 +8,14 @@ Contributing as a developer
:link: fork-the-repository
:link-type: ref

Learn how to fork the project and get your own copy.
Fork the project to create a copy.

.. grid-item-card:: :fa:`download` Clone the repository
:padding: 2 2 2 2
:link: clone-the-repository
:link-type: ref

Download your own copy in your local machine.
Clone the repository to download the copy to your local machine.

.. grid-item-card:: :fa:`download` Install for developers
:padding: 2 2 2 2
Expand All @@ -29,21 +29,22 @@ Contributing as a developer
:link: run-tests
:link-type: ref

Verify your changes by testing the project.
Verify your changes to the project by running tests.

.. grid-item-card:: :fa:`computer` Code style compliance
:padding: 2 2 2 2
:link: code-style
:link-type: ref

Adhere to code style
Adhere to code style.

.. grid-item-card:: :fa:`arrows-spin` Run the CI/CD pipelines
:padding: 2 2 2 2
:link: run-pipelines
:link-type: ref

Understand the different CI/CD pipelines.
Understand the different CI/CD pipelines that are executed
automatically.


.. _fork-the-repository:
Expand All @@ -52,13 +53,13 @@ Fork the repository
===================

Forking the repository is the first step to contributing to the project. This
allows you to have your own copy of the project so you can make changes without
allows you to have your own copy of the project so that you can make changes without
affecting the main project. Once you have made your changes, you can submit a
pull-request to the main project to have your changes reviewed and merged.
pull request to the main project to have your changes reviewed and merged.

.. button-link:: https://github.com/ansys/pyansys-heart/fork
:color: primary
:align: center
:align: left

:fa:`code-fork` Fork this project

Expand All @@ -71,44 +72,42 @@ pull-request to the main project to have your changes reviewed and merged.
Clone the repository
====================

Clone the latest version of PyAnsys Heart in development mode by running this code:
Clone the repository in development mode:

.. code-block:: bash

git clone https://github.com/pyansys/pyansys-heart

.. note::

If you are not an Ansys employee, you need to :ref:`fork the repository <fork-the-repository>` and
replace ``ansys`` with your GitHub user name in the ``git clone``
command.
If you are not an Ansys employee, you must :ref:`fork the repository <fork-the-repository>` and
replace ``ansys`` with your GitHub user name in the ``git clone`` command.

.. _install-for-developers:

Install for developers
======================

Installing PyAnsys Heart in development mode allows you to perform changes to the code
and see the changes reflected in your environment without having to reinstall
Installing PyAnsys Heart in development mode lets you change the code
and see these changes reflected in your environment without having to reinstall
the library every time you make a change.

Virtual environment
-------------------
Set up a virtual environment
----------------------------

Start by navigating to the project's root directory by running:
#. Navigate to the project's root directory :

.. code-block::

cd pyansys-heart
cd pyansys-heart

Then, create a new virtual environment named ``.venv`` to isolate your system's
Python environment by running:
#. Create a virtual environment named ``.venv`` to isolate your Python environment:

.. code-block:: text

python -m venv .venv

Finally, activate this environment by running:
#. Activate the virtual environment:

.. tab-set::

Expand All @@ -134,77 +133,77 @@ Finally, activate this environment by running:

source .venv/bin/activate

Development mode
----------------
Install in development mode
---------------------------

Now, install PyAnsys Heart in editable mode by running:
#. Install PyAnsys Heart in editable mode:

.. code-block:: text

python -m pip install --editable .
.. code-block:: text

Verify the installation by checking the version of the library:
python -m pip install --editable .

#. Verify the installation by checking the version of the library:

.. code-block:: python

from ansys.heart import __version__


print(f"PyAnsys Heart version is {__version__}")

.. jinja::

.. code-block:: text

>>> PyAnsys Heart version is {{ PYANSYS_HEART_VERSION }}
>>> PyAnsys Heart version is {{ PYANSYS_HEART_VERSION }}.

Install tox
Install Tox
-----------

Once the project is installed, you can install `tox`_. This is a cross-platform
Once the project is installed, you can install `Tox`_. This is a cross-platform
automation tool. The main advantage of Tox is that it eases routine tasks like project
testing, documentation generation, and wheel building in separate and isolated Python
virtual environments. To install Tox, run:
virtual environments.

.. code-block:: text
#. Install Tox:

.. code-block:: text

python -m pip install tox
python -m pip install tox

Finally, verify the installation by listing all the different environments
#. Verify the installation by listing all the different environments
(automation rules) for PyAnsys Heart:

.. code-block:: text
.. code-block:: text

python -m tox list
python -m tox list

.. jinja:: toxenvs
.. jinja:: toxenvs

.. dropdown:: Default Tox environments
:animate: fade-in
:icon: three-bars
.. dropdown:: Default Tox environments
:animate: fade-in
:icon: three-bars

.. list-table::
:header-rows: 1
:widths: auto
.. list-table::
:header-rows: 1
:widths: auto

* - Environment
- Description
{% for environment in envs %}
{% set name, description = environment.split("->") %}
* - {{ name }}
- {{ description }}
{% endfor %}
* - Environment
- Description
{% for environment in envs %}
{% set name, description = environment.split("->") %}
* - {{ name }}
- {{ description }}
{% endfor %}

.. _run-tests:

Run the tests
=============

Once you have made your changes, you can run the tests to verify that your
modifications did not break the project. PyAnsys Heart tests support different markers
to allow testing with/without coverage (and against specific python versions).
These markers are associated with dedicated `Tox`_ environments.
changes did not break the project. PyAnsys Heart tests support different markers
to allow testing with or without coverage (and against specific Python versions).
These markers are associated with dedicated Tox environments.

.. jinja:: toxenvs

Expand All @@ -228,9 +227,9 @@ These markers are associated with dedicated `Tox`_ environments.

.. Note::

The preceding test commands run all tests, including those that require Fluent (which take longer). For more
selective testing, ``-- -vv -m "not requires_fluent or (not extract_models)"`` or ``-- -vv -m "requires_fluent"`` can be
appended to tox testing commands.
The preceding test code runs all tests, including those that require Fluent (which take longer). For more
selective testing, append ``-- -vv -m "not requires_fluent or (not extract_models)"`` or ``-- -vv -m "requires_fluent"``
to Tox testing commands:

.. code:: bash

Expand All @@ -244,12 +243,12 @@ These markers are associated with dedicated `Tox`_ environments.
Check code style
================

PyAnsys Heart follows the PEP8 standard as outlined in
PyAnsys Heart follows the PEP 8 standard as described in
`PEP 8 <https://dev.docs.pyansys.com/coding-style/pep8.html>`_ in
the *PyAnsys Developer's Guide* and implements style checking using
the *PyAnsys developer's guide* and implements style checking using
`pre-commit <https://pre-commit.com/>`_.

To ensure your code meets minimum code styling standards, run the following tox environment:
To ensure your code meets minimum code styling standards, run the following Tox environment:

.. jinja:: toxenvs

Expand Down Expand Up @@ -293,10 +292,10 @@ Run CI/CD pipelines

PyAnsys Heart has a set of CI/CD pipelines that are executed automatically when certain
events are detected in the repository. Some of these events include opening a
pull-request, labelling a pull-request, and tagging a commit.
pull request, labeling a pull-request, and tagging a commit.

You can label a pull-request to skip certain jobs in the pipeline. Supported
labels are listed in the `PyAnsys Heart labels`_ page.
You can label a pull request to skip certain jobs in the pipeline. Supported
labels are listed on the `PyAnsys Heart labels`_ page.

.. list-table::
:widths: auto
Expand All @@ -305,4 +304,4 @@ labels are listed in the `PyAnsys Heart labels`_ page.
* - Label
- Description
* - ``test:skip``
- Skip the model generation tests
- Skip the model generation tests
Loading
Loading