Skip to content

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Oct 3, 2025

Description

  • for use in the MD workflow with combining surface bodies
  • combines two or more bodies with the SC Combine.Merge operation

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Oct 3, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner October 3, 2025 18:36
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 3, 2025
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.50%. Comparing base (99370ab) to head (5f8a472).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
- Coverage   94.50%   94.50%   -0.01%     
==========================================
  Files         169      169              
  Lines       11109    11126      +17     
==========================================
+ Hits        10499    10515      +16     
- Misses        610      611       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the note is added - LGTM! Thank you @jacobrkerstetter

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) October 7, 2025 09:00
@RobPasMue RobPasMue merged commit 782aa66 into main Oct 7, 2025
57 checks passed
@RobPasMue RobPasMue deleted the feat/stitch_bodies branch October 7, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants