Skip to content

Conversation

@syscordan
Copy link
Contributor

@syscordan syscordan commented Jul 14, 2025

Description

adding test coverage for modeler, plotting, logger, and parameters

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@syscordan syscordan self-assigned this Jul 14, 2025
@syscordan syscordan added the testing Anything related to tests label Jul 14, 2025
@syscordan syscordan requested a review from a team as a code owner July 14, 2025 14:00
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (8456fd7) to head (10c0b39).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2108      +/-   ##
==========================================
+ Coverage   93.66%   94.21%   +0.54%     
==========================================
  Files         138      138              
  Lines       10156    10156              
==========================================
+ Hits         9513     9568      +55     
+ Misses        643      588      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@syscordan syscordan requested a review from RobPasMue July 15, 2025 17:21
Copy link
Contributor

@RyanJWard RyanJWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@syscordan syscordan merged commit ac2c39f into main Jul 16, 2025
45 checks passed
@syscordan syscordan deleted the test/syscordan_logging_design_modeler branch July 16, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants