-
Notifications
You must be signed in to change notification settings - Fork 22
feat: nurbs sketching and surface support #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
a4e285f
nurbs sketch wip
jacobrkerstetter 79cd02f
sketch nurbs working with visualization
jacobrkerstetter f11312f
doc edits
jacobrkerstetter 9636f22
added degree check for fitting from < 4 points
jacobrkerstetter 8f8cc96
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
jacobrkerstetter 38b92b0
adding contains_point for nurbs edge
jacobrkerstetter a1ffa39
added test to create a surface from a combination of nurbs and segmen…
jacobrkerstetter e591136
add fill command
jacobrkerstetter 8a3bab5
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
jacobrkerstetter 2ee3921
added test for creating surface from nurbs sketch + overhanging edges
jacobrkerstetter 6d25316
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 2bca7ab
chore: adding changelog file 2104.added.md [dependabot-skip]
pyansys-ci-bot a7dc888
code cleanup
jacobrkerstetter 6e600ea
Merge branch 'feat/nurbs_sketching' of https://github.com/ansys/pyans…
jacobrkerstetter 9601df4
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 1b5f78e
more cleanup
jacobrkerstetter d00f558
Merge branch 'feat/nurbs_sketching' of https://github.com/ansys/pyans…
jacobrkerstetter c931225
Merge branch 'main' into feat/nurbs_sketching
jacobrkerstetter a8f91e6
bump protos version
jacobrkerstetter 9f65d13
remove plot statement used for testing
jacobrkerstetter 0846adb
Merge branch 'main' into feat/nurbs_sketching
jacobrkerstetter cdf6400
resolving PR comments
jacobrkerstetter 946a530
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 12e9b6b
Merge branch 'main' into feat/nurbs_sketching
jacobrkerstetter 61d4883
Merge branch 'main' into feat/nurbs_sketching
jacobrkerstetter 768158a
remove double import
jacobrkerstetter 4704a4a
Merge branch 'feat/nurbs_sketching' of https://github.com/ansys/pyans…
jacobrkerstetter 16fe900
remove double import
jacobrkerstetter d982367
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] 21958aa
add warning for nurbs sketching being unavailable before 26r1
jacobrkerstetter fbf8705
Merge branch 'feat/nurbs_sketching' of https://github.com/ansys/pyans…
jacobrkerstetter 3506be9
fixing docs order
jacobrkerstetter 80e7c0e
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Nurbs sketching and surface support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobrkerstetter marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.