support for redis7 group family for parameter groups #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 12s (non-voting) |
Member
|
Can you also add a changelog fragment? Otherwise it looks good to me |
Member
|
it's just that diff --git a/changelogs/fragments/2254-add-redis7x-cache-parameter-group-family.yml b/changelogs/fragments/2254-add-redis7x-cache-parameter-group-family.yml
new file mode 100644
index 00000000..7a97f631
--- /dev/null
+++ b/changelogs/fragments/2254-add-redis7x-cache-parameter-group-family.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - elasticache_parameter_group - add ``redis7.x`` group family on the module input choices (https://github.com/ansible-collections/community.aws/pull/2254).and we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AWS cache parameters groups can now be of type redis7. This PR adds to the module elasticache_parameter_group support to pass this new family group.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
Impacted component: elasticache_parameter_group module.