Skip to content

Conversation

@abikouo
Copy link
Contributor

@abikouo abikouo commented Oct 2, 2024

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_launch_template

@github-actions
Copy link

github-actions bot commented Oct 2, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

Change ansible-collections/amazon.aws#2319 is needed.

@abikouo
Copy link
Contributor Author

abikouo commented Oct 2, 2024

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c90993864d7448bfba32d477d2b8eab4

✔️ ansible-galaxy-importer SUCCESS in 3m 24s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 26s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-community.aws-1 SUCCESS in 16m 30s
integration-community.aws-2 FAILURE in 8m 15s
✔️ integration-community.aws-3 SUCCESS in 7m 14s
✔️ integration-community.aws-4 SUCCESS in 6m 35s
✔️ integration-community.aws-5 SUCCESS in 5m 37s
✔️ integration-community.aws-6 SUCCESS in 6m 25s
✔️ integration-community.aws-7 SUCCESS in 7m 59s
✔️ integration-community.aws-8 SUCCESS in 8m 21s
✔️ integration-community.aws-9 SUCCESS in 7m 30s
Skipped 13 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f3b79426238243558eb00777238fbb37

ansible-galaxy-importer FAILURE in 4m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 45s
✔️ ansible-test-splitter SUCCESS in 4m 23s
✔️ integration-community.aws-1 SUCCESS in 17m 05s
integration-community.aws-2 FAILURE in 7m 14s
✔️ integration-community.aws-3 SUCCESS in 5m 28s
✔️ integration-community.aws-4 SUCCESS in 7m 13s
✔️ integration-community.aws-5 SUCCESS in 6m 27s
✔️ integration-community.aws-6 SUCCESS in 6m 21s
✔️ integration-community.aws-7 SUCCESS in 9m 22s
✔️ integration-community.aws-8 SUCCESS in 10m 20s
✔️ integration-community.aws-9 SUCCESS in 5m 55s
Skipped 13 jobs

@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

Change ansible-collections/amazon.aws#2319 is needed.

@abikouo abikouo force-pushed the prepapre_ec2_launch_template_v1 branch from e2139a5 to 24ea7ae Compare October 8, 2024 13:38
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9c39937ea8b44594b5263bb57966c10e

ansible-galaxy-importer FAILURE in 5m 51s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 45s
✔️ ansible-test-splitter SUCCESS in 4m 26s
✔️ integration-community.aws-1 SUCCESS in 19m 55s
✔️ integration-community.aws-2 SUCCESS in 7m 04s
✔️ integration-community.aws-3 SUCCESS in 5m 54s
integration-community.aws-4 RETRY_LIMIT in 1m 54s
✔️ integration-community.aws-5 SUCCESS in 6m 33s
✔️ integration-community.aws-6 SUCCESS in 6m 19s
✔️ integration-community.aws-7 SUCCESS in 6m 42s
✔️ integration-community.aws-8 SUCCESS in 9m 24s
✔️ integration-community.aws-9 SUCCESS in 6m 35s
Skipped 13 jobs

@abikouo abikouo requested a review from alinabuzachis October 10, 2024 10:09
@abikouo abikouo force-pushed the prepapre_ec2_launch_template_v1 branch from 24ea7ae to cbdd9d8 Compare October 11, 2024 13:39
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/deb3cf7367e745f4933aebb76909b0ee

✔️ ansible-galaxy-importer SUCCESS in 3m 25s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 09s
✔️ ansible-test-splitter SUCCESS in 4m 37s
✔️ integration-community.aws-1 SUCCESS in 14m 44s
✔️ integration-community.aws-2 SUCCESS in 6m 51s
✔️ integration-community.aws-3 SUCCESS in 4m 40s
✔️ integration-community.aws-4 SUCCESS in 6m 58s
✔️ integration-community.aws-5 SUCCESS in 5m 38s
✔️ integration-community.aws-6 SUCCESS in 6m 56s
✔️ integration-community.aws-7 SUCCESS in 8m 48s
✔️ integration-community.aws-8 SUCCESS in 9m 13s
✔️ integration-community.aws-9 SUCCESS in 6m 42s
Skipped 13 jobs

@abikouo abikouo force-pushed the prepapre_ec2_launch_template_v1 branch from cbdd9d8 to a74d629 Compare October 17, 2024 16:17
@abikouo abikouo requested a review from alinabuzachis October 17, 2024 16:18
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0bc730c602ed40e7b4691bebbeb330f7

ansible-galaxy-importer FAILURE in 4m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 05s
✔️ ansible-test-splitter SUCCESS in 4m 04s
✔️ integration-community.aws-1 SUCCESS in 9m 04s
Skipped 21 jobs

Copy link
Contributor

@GomathiselviS GomathiselviS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typo errors need to be fixed.

type: str
description: >
- Wether the instance metadata endpoint is available via IPv6 (C(enabled)) or not (C(disabled)).
- Wether the instance metadata endpoint is available via IPv6 (V(enabled)) or not (V(disabled)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Wether the instance metadata endpoint is available via IPv6 (V(enabled)) or not (V(disabled)).
- Whether the instance metadata endpoint is available via IPv6 (V(enabled)) or not (V(disabled)).

@abikouo abikouo force-pushed the prepapre_ec2_launch_template_v1 branch from dc4bfc1 to 79ac649 Compare October 18, 2024 13:28
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/01e644f7b78a4040a43c03b2af22272a

ansible-galaxy-importer FAILURE in 7m 38s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 30s
✔️ ansible-test-splitter SUCCESS in 4m 10s
✔️ integration-community.aws-1 SUCCESS in 8m 02s
Skipped 21 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Oct 18, 2024
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/4c8b4fb0e05848fc9d21a04126c66176

ansible-galaxy-importer FAILURE in 4m 55s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 14s
✔️ ansible-test-splitter SUCCESS in 3m 49s
✔️ integration-community.aws-1 SUCCESS in 7m 39s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 40d61f0 into ansible-collections:main Oct 18, 2024
66 of 67 checks passed
alinabuzachis pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2024
…#2164)

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
alinabuzachis pushed a commit to GomathiselviS/community.aws that referenced this pull request Oct 25, 2024
…#2164)

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
boutetnico pushed a commit to boutetnico/community.aws that referenced this pull request Oct 13, 2025
…#2164)

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge the PR (SoftwareFactory)

Projects

None yet

3 participants