Skip to content

Prepare modules ec2_vpc_nacl and ec2_vpc_nacl_info for promotion #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 14, 2024
Merged

Prepare modules ec2_vpc_nacl and ec2_vpc_nacl_info for promotion #2159

merged 5 commits into from
Oct 14, 2024

Conversation

@abikouo
Copy link
Contributor

@abikouo abikouo commented Sep 25, 2024 •
edited
Loading

SUMMARY
  • Use shared code from amazon.aws.plugins.module_utils.ec2
  • Refactor module ec2_vpc_nacl and ec2_vpc_nacl_info
ISSUE TYPE
  • Feature Pull Request

@github-actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@abikouo abikouo force-pushed the prepare_ec2_vpc_nacl_v1 branch from d56d884 to 469202d Compare September 26, 2024 09:56
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Sep 26, 2024

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/44375fe4e33a47628a926090e01ba448

❌ ansible-galaxy-importer FAILURE in 5m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 00s
✔️ ansible-test-splitter SUCCESS in 4m 23s
✔️ integration-community.aws-1 SUCCESS in 17m 20s
✔️ integration-community.aws-2 SUCCESS in 6m 51s
✔️ integration-community.aws-3 SUCCESS in 7m 05s
✔️ integration-community.aws-4 SUCCESS in 8m 05s
✔️ integration-community.aws-5 SUCCESS in 8m 04s
✔️ integration-community.aws-6 SUCCESS in 9m 50s
✔️ integration-community.aws-7 SUCCESS in 5m 13s
Skipped 15 jobs

alinabuzachis
alinabuzachis reviewed Oct 4, 2024
View reviewed changes
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Oct 9, 2024

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/87e18fddf50949a2b8fd4d1e5b63f821

❌ ansible-galaxy-importer FAILURE in 5m 00s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 06s
✔️ ansible-test-splitter SUCCESS in 4m 23s
✔️ integration-community.aws-1 SUCCESS in 8m 31s
Skipped 21 jobs

@abikouo abikouo force-pushed the prepare_ec2_vpc_nacl_v1 branch from 130f908 to da65df1 Compare October 10, 2024 09:15
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Oct 10, 2024

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4c6f17171e7c4493ad1c223d6aa29b36

✔️ ansible-galaxy-importer SUCCESS in 3m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 41s
✔️ ansible-test-splitter SUCCESS in 4m 24s
✔️ integration-community.aws-1 SUCCESS in 6m 36s
Skipped 21 jobs

GomathiselviS
GomathiselviS reviewed Oct 10, 2024
View reviewed changes
@abikouo abikouo requested a review from GomathiselviS October 11, 2024 15:35
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Oct 11, 2024

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/14eeffe008054852a6007c8109dfbd92

✔️ ansible-galaxy-importer SUCCESS in 3m 24s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 51s
✔️ ansible-test-splitter SUCCESS in 4m 31s
✔️ integration-community.aws-1 SUCCESS in 17m 49s
✔️ integration-community.aws-2 SUCCESS in 6m 57s
✔️ integration-community.aws-3 SUCCESS in 8m 23s
✔️ integration-community.aws-4 SUCCESS in 5m 25s
✔️ integration-community.aws-5 SUCCESS in 5m 53s
✔️ integration-community.aws-6 SUCCESS in 7m 20s
✔️ integration-community.aws-7 SUCCESS in 11m 13s
✔️ integration-community.aws-8 SUCCESS in 5m 17s
Skipped 14 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Oct 14, 2024
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Oct 14, 2024

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/0657894434df46de95bc5090c4c88273

Warning:
Change 2319 in project ansible-collections/amazon.aws does not share a change queue with 2159 in project ansible-collections/community.aws

@abikouo
Copy link
Contributor Author

abikouo commented Oct 14, 2024

regate

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Oct 14, 2024

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8a9bb1c10c064f709bf9957ed170251e

❌ ansible-galaxy-importer FAILURE in 7m 12s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 38s
✔️ ansible-test-splitter SUCCESS in 5m 19s
✔️ integration-community.aws-1 SUCCESS in 7m 47s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 86d268f into ansible-collections:main Oct 14, 2024
67 checks passed
boutetnico pushed a commit to boutetnico/community.aws that referenced this pull request Oct 13, 2025
@abikouo @boutetnico
Prepare modules ec2_vpc_nacl and ec2_vpc_nacl_info for promotion (ans…
8f401f8 
…ible-collections#2159)

SUMMARY


Use shared code from amazon.aws.plugins.module_utils.ec2
Refactor module ec2_vpc_nacl and ec2_vpc_nacl_info


ISSUE TYPE


Feature Pull Request

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GomathiselviS GomathiselviS GomathiselviS approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

@mandar242 mandar242 Awaiting requested review from mandar242

Assignees

No one assigned

Labels

mergeit Merge the PR (SoftwareFactory)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abikouo @alinabuzachis @GomathiselviS