Add support to enable multicast on transit gateway #2063

cschimid · 2024-03-28T12:15:17Z

SUMMARY

Need to enable multicast while creating transit gateway

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

transit_gateway

ADDITIONAL INFORMATION

cschimid · 2024-03-28T12:17:24Z

I have successfully tested the module by creating a transit gateway with multicast enabled

github-actions · 2024-03-28T12:18:49Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2024-03-28T13:00:08Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ae11f6478f7546019fc2556b324ffabb

✔️ ansible-galaxy-importer SUCCESS in 4m 51s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 53s
✔️ ansible-test-splitter SUCCESS in 6m 14s
✔️ integration-community.aws-1 SUCCESS in 27m 15s
✔️ integration-community.aws-2 SUCCESS in 10m 50s
Skipped 20 jobs

Correction on doc section for multicast option

softwarefactory-project-zuul · 2024-04-02T13:00:46Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c67c7990e1ee4d23a5d30c3ad87db63a

✔️ ansible-galaxy-importer SUCCESS in 6m 18s (non-voting)
✔️ build-ansible-collection SUCCESS in 17m 52s
✔️ ansible-test-splitter SUCCESS in 7m 13s
✔️ integration-community.aws-1 SUCCESS in 30m 03s
✔️ integration-community.aws-2 SUCCESS in 9m 23s
Skipped 20 jobs

alinabuzachis

@cschimid Thank you for taking time to work on this feature. Can you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment and an integration test for this new feature? Thanks.

CHANGELOG.rst

plugins/modules/ec2_transit_gateway.py

plugins/modules/ec2_transit_gateway_info.py

plugins/modules/ec2_transit_gateway.py

softwarefactory-project-zuul · 2024-04-04T15:42:46Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/76624bdbdcf54d9b944e74aee08001de

✔️ ansible-galaxy-importer SUCCESS in 4m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 18m 03s
✔️ ansible-test-splitter SUCCESS in 5m 21s
✔️ integration-community.aws-1 SUCCESS in 33m 39s
✔️ integration-community.aws-2 SUCCESS in 11m 31s
Skipped 20 jobs

plugins/modules/ec2_transit_gateway.py

tests/integration/targets/ec2_transit_gateway/tasks/main.yml

Co-authored-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-04-04T17:12:53Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/99744ca9f84e44419a8933938e0040d0

✔️ ansible-galaxy-importer SUCCESS in 4m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 24s
✔️ ansible-test-splitter SUCCESS in 5m 44s
✔️ integration-community.aws-1 SUCCESS in 34m 01s
❌ integration-community.aws-2 FAILURE in 11m 22s
Skipped 20 jobs

… enabled

softwarefactory-project-zuul · 2024-04-04T18:55:47Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/851a7033219a47ee9316b0431af09c11

❌ ansible-galaxy-importer FAILURE in 5m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 10s
✔️ ansible-test-splitter SUCCESS in 5m 43s
✔️ integration-community.aws-1 SUCCESS in 27m 26s
❌ integration-community.aws-2 FAILURE in 6m 26s
Skipped 20 jobs

softwarefactory-project-zuul · 2024-04-05T08:50:16Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/37a2613486c042289bbd3eefda501e7c

❌ ansible-galaxy-importer FAILURE in 5m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 23m 40s
✔️ ansible-test-splitter SUCCESS in 9m 11s
✔️ integration-community.aws-1 SUCCESS in 49m 15s
❌ integration-community.aws-2 FAILURE in 10m 25s
Skipped 20 jobs

tests/integration/targets/ec2_transit_gateway/tasks/main.yml

Co-authored-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-04-05T12:25:24Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5604a4ba5abb491cbd231811f3758790

❌ ansible-galaxy-importer FAILURE in 5m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 31s
✔️ ansible-test-splitter SUCCESS in 5m 26s
✔️ integration-community.aws-1 SUCCESS in 28m 21s
❌ integration-community.aws-2 FAILURE in 16m 52s
Skipped 20 jobs

softwarefactory-project-zuul · 2024-04-05T13:52:12Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/50f6a8f496f84710afc9eae2123409b3

❌ ansible-galaxy-importer FAILURE in 5m 27s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 02s
✔️ ansible-test-splitter SUCCESS in 5m 21s
✔️ integration-community.aws-1 SUCCESS in 28m 02s
✔️ integration-community.aws-2 SUCCESS in 11m 21s
Skipped 20 jobs

softwarefactory-project-zuul · 2024-04-08T16:14:45Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/726f0991ca514cb0b720d527c05f748a

✔️ ansible-galaxy-importer SUCCESS in 4m 58s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 30s
✔️ ansible-test-splitter SUCCESS in 7m 15s
✔️ integration-community.aws-1 SUCCESS in 28m 14s
✔️ integration-community.aws-2 SUCCESS in 11m 02s
Skipped 20 jobs

alinabuzachis · 2024-04-09T10:00:05Z

CHANGELOG.rst


 .. contents:: Topics

-v7.2.0


@cschimid You should restore this part.

softwarefactory-project-zuul · 2024-04-09T11:40:15Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a7b6efacb8f24d37a862a9ac01412874

❌ ansible-galaxy-importer FAILURE in 5m 23s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 09s
✔️ ansible-test-splitter SUCCESS in 5m 39s
✔️ integration-community.aws-1 SUCCESS in 28m 23s
✔️ integration-community.aws-2 SUCCESS in 12m 07s
Skipped 20 jobs

plugins/modules/ec2_transit_gateway.py

softwarefactory-project-zuul · 2024-07-02T14:33:10Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/59b2139a051f4dbdb10df9942ce6e765

❌ ansible-galaxy-importer FAILURE in 4m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 36s
✔️ ansible-test-splitter SUCCESS in 5m 02s
✔️ integration-community.aws-1 SUCCESS in 26m 40s
✔️ integration-community.aws-2 SUCCESS in 8m 43s
Skipped 20 jobs

patchback · 2024-07-02T14:33:14Z

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/4752c05c56076e1b904d7ee4dfd6c350601da0af/pr-2063

Backported as #2119

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

SUMMARY Need to enable multicast while creating transit gateway ISSUE TYPE Feature Pull Request COMPONENT NAME transit_gateway ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Carlos Schimidt Reviewed-by: Mark Chappell (cherry picked from commit 4752c05)

This is a backport of PR #2063 as merged into main (4752c05). SUMMARY Need to enable multicast while creating transit gateway ISSUE TYPE Feature Pull Request COMPONENT NAME transit_gateway ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

…ns#2063) SUMMARY Need to enable multicast while creating transit gateway ISSUE TYPE Feature Pull Request COMPONENT NAME transit_gateway ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Carlos Schimidt Reviewed-by: Mark Chappell

cschimid and others added 3 commits March 28, 2024 06:58

Add support for multicast option on transit gateway

23fe103

Add support for Multicast option on Transit Gateway

1887e2a

Add info about multicast support for transit gateway

e01eb5a

cschimid added 2 commits April 2, 2024 08:54

Update ec2_transit_gateway_info.py

114639f

Correction on doc section for multicast option

Update ec2_transit_gateway_info.py

af489f8

alinabuzachis reviewed Apr 4, 2024

View reviewed changes

CHANGELOG.rst Show resolved Hide resolved

plugins/modules/ec2_transit_gateway.py Show resolved Hide resolved

plugins/modules/ec2_transit_gateway.py Show resolved Hide resolved

plugins/modules/ec2_transit_gateway_info.py Show resolved Hide resolved

cschimid added 8 commits April 4, 2024 09:43

Create 2063-add-multicast-support.yml

b207886

Added version_added: 7.3.0 to ec2_transit_gateway.py

4025c20

Added version_added: 7.3.0 to ec2_transit_gateway_info.py

00b94ba

Added options.multicast-support: enable to teste with multiple filters

9dca7b1

Removed incorrectly inserted text on CHANGELOG.rst

19abc5b

changed default to false for multicast support

00a1009

Changed default to False for Multicast Support

a58da99

removed default for multicast support

a49e45b

abikouo reviewed Apr 4, 2024

View reviewed changes

plugins/modules/ec2_transit_gateway.py Show resolved Hide resolved

alinabuzachis reviewed Apr 4, 2024

View reviewed changes

plugins/modules/ec2_transit_gateway.py Outdated Show resolved Hide resolved

tests/integration/targets/ec2_transit_gateway/tasks/main.yml Outdated Show resolved Hide resolved

Update plugins/modules/ec2_transit_gateway.py

75c0c71

Co-authored-by: Alina Buzachis <[email protected]>

cschimid added 3 commits April 4, 2024 14:17

Add integration test to create with multicast enabled and check if is…

2250714

… enabled

removed multicast filter from multiple filters test

dc93baa

fix multicast test

986c5ec

cschimid added 2 commits April 4, 2024 16:30

fix multicast test

e78a2c9

Update main.yml

94f59e4

alinabuzachis reviewed Apr 5, 2024

View reviewed changes

tests/integration/targets/ec2_transit_gateway/tasks/main.yml Outdated Show resolved Hide resolved

tests/integration/targets/ec2_transit_gateway/tasks/main.yml Show resolved Hide resolved

cschimid and others added 2 commits April 5, 2024 08:37

Update tests/integration/targets/ec2_transit_gateway/tasks/main.yml

3c3a8f7

Co-authored-by: Alina Buzachis <[email protected]>

fix some multicast tests

f4e0de5

fix issues with multicast test

4519746

cschimid added 2 commits April 8, 2024 12:22

Remove trailing whitespace to fix transitgateway.py

d7b5ae9

Merge branch 'main' into main

8959e35

alinabuzachis reviewed Apr 9, 2024

View reviewed changes

CHANGELOG.rst

.. contents:: Topics

v7.2.0

Copy link

Contributor

alinabuzachis Apr 9, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschimid You should restore this part.

cschimid added 2 commits April 9, 2024 07:33

fixed CHANGELOG.rst

47b0a30

try to remove trainling whitespace on line 9 ec2_transit_gateway_info.py

c6c67f3

alinabuzachis approved these changes Apr 9, 2024

View reviewed changes

alinabuzachis requested a review from abikouo July 2, 2024 13:19

alinabuzachis added the backport-8 PR should be backported to the stable-8 branch label Jul 2, 2024

abikouo approved these changes Jul 2, 2024

View reviewed changes

tremble approved these changes Jul 2, 2024

View reviewed changes

plugins/modules/ec2_transit_gateway.py Outdated Show resolved Hide resolved

bump version_added

e90b8bd

tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 2, 2024

softwarefactory-project-zuul bot merged commit 4752c05 into ansible-collections:main Jul 2, 2024

patchback bot mentioned this pull request Jul 2, 2024

[PR #2063/4752c05c backport][stable-8] Add support to enable multicast on transit gateway #2119

Merged

Add support to enable multicast on transit gateway #2063

Add support to enable multicast on transit gateway #2063

Uh oh!

Conversation

cschimid commented Mar 28, 2024

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Uh oh!

cschimid commented Mar 28, 2024

Uh oh!

github-actions bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docs Build 📝

Uh oh!

softwarefactory-project-zuul bot commented Mar 28, 2024

Uh oh!

softwarefactory-project-zuul bot commented Apr 2, 2024

Uh oh!

alinabuzachis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Apr 4, 2024

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Apr 4, 2024

Uh oh!

softwarefactory-project-zuul bot commented Apr 4, 2024

Uh oh!

softwarefactory-project-zuul bot commented Apr 5, 2024

Uh oh!

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Apr 5, 2024

Uh oh!

softwarefactory-project-zuul bot commented Apr 5, 2024

Uh oh!

softwarefactory-project-zuul bot commented Apr 8, 2024

Uh oh!

alinabuzachis Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Apr 9, 2024

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Jul 2, 2024

Uh oh!

patchback bot commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to stable-8: 💚 backport PR created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 28, 2024 •

edited

Loading

alinabuzachis Apr 9, 2024 •

edited

Loading

patchback bot commented Jul 2, 2024 •

edited

Loading