Skip to content

Conversation

@tremble
Copy link
Contributor

@tremble tremble commented Jul 22, 2022

SUMMARY

fixes: #915

elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn. While this is shown in the examples, it's in the options documentation.

While undocumented the feature's been there since at release 1.0.0

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py

ADDITIONAL INFORMATION

@tremble tremble added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Jul 22, 2022
@github-actions
Copy link

github-actions bot commented Jul 22, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 5m 10s
ansible-test-sanity-docker-devel RETRY_LIMIT in 4m 50s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 25s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 25s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 46s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 7m 57s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 32s
✔️ build-ansible-collection SUCCESS in 4m 52s
ansible-test-sanity-docker-devel RETRY_LIMIT in 4m 47s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 17s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 07s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 40s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 56s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 11m 07s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9fe9fc4 into ansible-collections:main Jul 22, 2022
@patchback
Copy link

patchback bot commented Jul 22, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/9fe9fc458dcb86aba8049e7531029346fa31bc0e/pr-1366

Backported as #1367

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 22, 2022
elb_application_lb/elb_network_lb - Add documentation for TargetGroupName

SUMMARY
fixes: #915
elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn.  While this is shown in the examples, it's in the options documentation.
While undocumented the feature's been there since at release 1.0.0
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 9fe9fc4)
@patchback
Copy link

patchback bot commented Jul 22, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/9fe9fc458dcb86aba8049e7531029346fa31bc0e/pr-1366

Backported as #1368

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 22, 2022
elb_application_lb/elb_network_lb - Add documentation for TargetGroupName

SUMMARY
fixes: #915
elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn.  While this is shown in the examples, it's in the options documentation.
While undocumented the feature's been there since at release 1.0.0
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 9fe9fc4)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 22, 2022
[PR #1366/9fe9fc45 backport][stable-4] elb_application_lb/elb_network_lb - Add documentation for TargetGroupName

This is a backport of PR #1366 as merged into main (9fe9fc4).
SUMMARY
fixes: #915
elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn.  While this is shown in the examples, it's in the options documentation.
While undocumented the feature's been there since at release 1.0.0
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 22, 2022
[PR #1366/9fe9fc45 backport][stable-3] elb_application_lb/elb_network_lb - Add documentation for TargetGroupName

This is a backport of PR #1366 as merged into main (9fe9fc4).
SUMMARY
fixes: #915
elb_application_lb and elb_network_lb have a poorly documented feature, that you can use TargetGroupName instead of TargetGroupArn.  While this is shown in the examples, it's in the options documentation.
While undocumented the feature's been there since at release 1.0.0
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the issues/915 branch September 9, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch community_review docs mergeit Merge the PR (SoftwareFactory) module module owner_pr PR created by owner/maintainer plugins plugin (any type)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflict between ALB documentation and examples

3 participants