[PR #1105/77cb0974 backport][stable-3] rds_instance - add deletion_protection param #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rds_instance - add deletion_protection param Depends-On: #1116 SUMMARY Fixes #922 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 77cb097)
alinabuzachis
approved these changes
May 9, 2022
ansibullbot
added
community_review
feature
Contributor
Contributor
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/77cb09740beb34940ba678495a0d60768bce2d70/pr-1105
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ns#1138) Fix AttributeError when running ec2_metadata_facts SUMMARY Prior to 5.0.0 we caught "Exception" within fetch, this was limited to json.JSONDecodeError, however it looks like we also needed to catch AttributeError for non-dict JSON ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION fixes: ansible-collections#1134
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Enable ec2_metadata integration tests SUMMARY Enable ec2_metadata_facts integration tests ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION As shown by ansible-collections#1138 we should try to ensure that the integration tests are enabled Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1105 as merged into main (77cb097).
Depends-On: #1116
SUMMARY
Fixes #922
ISSUE TYPE
COMPONENT NAME
rds_instance