Skip to content

Conversation

@patchback
Copy link

@patchback patchback bot commented Jul 6, 2022

This is a backport of PR #915 as merged into main (8ce9c19).

SUMMARY

fixes: #589
fixes: #914

Fixes two NoneType related bugs when creating new ELBs.

(includes extra tests this time to trigger the bugs)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/elb_classic_lb.py

ADDITIONAL INFORMATION

Fix NoneType errors with elb_classic_lb

SUMMARY
fixes: #589
fixes: #914
Fixes two NoneType related bugs when creating new ELBs.
(includes extra tests this time to trigger the bugs)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/elb_classic_lb.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 8ce9c19)
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jul 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 6m 22s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 28s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 47s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 08s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 38s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 51s
✔️ ansible-test-splitter SUCCESS in 2m 51s
✔️ integration-amazon.aws-1 SUCCESS in 27m 50s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 5m 16s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 52s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 27s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 51s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 25s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 36s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-amazon.aws-1 SUCCESS in 21m 48s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cc9d8dc into stable-3 Jul 6, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/8ce9c198da3cc15424b97046fe340c2a20b646c9/pr-915 branch July 6, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants