Update s3 module_util validate_bucket_name to accept 3 character bucket name #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit test cases for 2 and 3 character bucket names
ansibullbot
added
bug
Contributor
Contributor
alinabuzachis
approved these changes
May 9, 2022
Collaborator
alinabuzachis
left a comment
alinabuzachis
left a comment
There was a problem hiding this comment.
@jbellanti Thank you. LGTM!
Contributor
Author
|
recheck |
Contributor
goneri
approved these changes
May 10, 2022
Member
|
Thank you for the contribution @jbellanti |
goneri
added
backport-2
Contributor
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #807 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 10, 2022
…et name (#802) Update s3 module_util validate_bucket_name to accept 3 character bucket name SUMMARY According to the S3 docs (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html), the minimum bucket name is 3 characters. The current validate_bucket_name function fails for any bucket name less than 4 characters. This PR updates the check and adds unit test cases for minimum length. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3 ADDITIONAL INFORMATION To reproduce, attempt to perform an action on a bucket with a 3 character name. Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <[email protected]> (cherry picked from commit 93b8370)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #808 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 10, 2022
…et name (#802) Update s3 module_util validate_bucket_name to accept 3 character bucket name SUMMARY According to the S3 docs (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html), the minimum bucket name is 3 characters. The current validate_bucket_name function fails for any bucket name less than 4 characters. This PR updates the check and adds unit test cases for minimum length. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3 ADDITIONAL INFORMATION To reproduce, attempt to perform an action on a bucket with a 3 character name. Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <[email protected]> (cherry picked from commit 93b8370)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 19, 2022
…et name (#802) (#808) [PR #802/93b83706 backport][stable-3] Update s3 module_util validate_bucket_name to accept 3 character bucket name This is a backport of PR #802 as merged into main (93b8370). SUMMARY According to the S3 docs (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html), the minimum bucket name is 3 characters. The current validate_bucket_name function fails for any bucket name less than 4 characters. This PR updates the check and adds unit test cases for minimum length. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3 ADDITIONAL INFORMATION To reproduce, attempt to perform an action on a bucket with a 3 character name. Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 24, 2022
…et name (#802) (#807) [PR #802/93b83706 backport][stable-2] Update s3 module_util validate_bucket_name to accept 3 character bucket name This is a backport of PR #802 as merged into main (93b8370). SUMMARY According to the S3 docs (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html), the minimum bucket name is 3 characters. The current validate_bucket_name function fails for any bucket name less than 4 characters. This PR updates the check and adds unit test cases for minimum length. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3 ADDITIONAL INFORMATION To reproduce, attempt to perform an action on a bucket with a 3 character name. Reviewed-by: Mark Chappell <None>
1 task
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2b01e9c
1 task
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2b01e9c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2b01e9c
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2b01e9c
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Route53: fix diff mode when state: absent SUMMARY Fix diff mode when state: absend ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 Reviewed-by: Felix Fontein <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
According to the S3 docs (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html), the minimum bucket name is 3 characters. The current
validate_bucket_namefunction fails for any bucket name less than 4 characters. This PR updates the check and adds unit test cases for minimum length.ISSUE TYPE
COMPONENT NAME
s3
ADDITIONAL INFORMATION
To reproduce, attempt to perform an action on a bucket with a 3 character name.