ec2_vpc_route_table - support associating internet gateways #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
Contributor
Contributor
Collaborator
|
@jatorcasso I'll debug the module ec2_vpc_igw module tomorrow, but if you want to anticipate feel free to do it. |
Collaborator
|
recheck |
Contributor
Contributor
Author
|
recheck |
Contributor
Contributor
|
recheck |
Contributor
Member
|
recheck |
Contributor
|
This change depends on a change that failed to merge. |
Member
|
recheck |
Contributor
mandar242
reviewed
Feb 25, 2022
Contributor
mandar242
left a comment
mandar242
left a comment
There was a problem hiding this comment.
just minor things - otherwise LGTM!
Contributor
Contributor
Akasurde
reviewed
Feb 28, 2022
Akasurde
reviewed
Feb 28, 2022
Akasurde
reviewed
Feb 28, 2022
Akasurde
reviewed
Feb 28, 2022
Akasurde
reviewed
Feb 28, 2022
Contributor
Contributor
Author
|
recheck |
Contributor
alinabuzachis
added
mergeit
Contributor
Contributor
|
recheck |
Contributor
1 task
alinabuzachis
dismissed
abikouo’s stale review
It hangs merging and it seems the requests have been addressed.
Collaborator
|
regate |
Contributor
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #757 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
ec2_vpc_route_table - support associating internet gateways Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Update ec2_vpc_route_table to support associating internet gateways per feature request #476 Add integration tests Fix idempotency issue when associating a subnet with a route table ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Mark Woolley <[email protected]> (cherry picked from commit d9d5d0d)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
) [PR #690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways This is a backport of PR #690 as merged into main (d9d5d0d). Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Update ec2_vpc_route_table to support associating internet gateways per feature request #476 Add integration tests Fix idempotency issue when associating a subnet with a route table ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Mar 31, 2022
…collections#690) (ansible-collections#757) [PR ansible-collections#690/d9d5d0d7 backport][stable-3] ec2_vpc_route_table - support associating internet gateways This is a backport of PR ansible-collections#690 as merged into main (d9d5d0d). Depends-On: ansible/ansible-zuul-jobs#1362 Depends-On: ansible/ansible-zuul-jobs#1364 SUMMARY Update ec2_vpc_route_table to support associating internet gateways per feature request ansible-collections#476 Add integration tests Fix idempotency issue when associating a subnet with a route table ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_route_table
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1362
Depends-On: ansible/ansible-zuul-jobs#1364
SUMMARY
ISSUE TYPE
COMPONENT NAME
ec2_vpc_route_table