Skip to content

Conversation

@patchback
Copy link

@patchback patchback bot commented Aug 30, 2023

This is a backport of PR #1716 as merged into main (39b19d8).

SUMMARY

"When creating a new keypair the ec2_key module prints out the private key directly to the standard output. This makes it unusable in any kind of public workflow."

To fix this security vulnerability no_log and register should be used while using this module to create a keypair.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

…r. (#1716)

Update document to use no_log and register when creating a new keypair

SUMMARY

"When creating a new keypair the ec2_key module prints out the private key directly to the standard output. This makes it unusable in any kind of public workflow."
To fix this security vulnerability no_log and register should be used while using this module to create a keypair.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Alina Buzachis
(cherry picked from commit 39b19d8)
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1bcd5726b5db402d912a8955a67fab28

✔️ ansible-galaxy-importer SUCCESS in 5m 29s
✔️ build-ansible-collection SUCCESS in 12m 25s
✔️ ansible-test-splitter SUCCESS in 4m 49s
✔️ integration-amazon.aws-1 SUCCESS in 9m 57s
Skipped 43 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Aug 31, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b333e846fd8c4063994045c0990ab8b1

✔️ ansible-galaxy-importer SUCCESS in 5m 02s
✔️ build-ansible-collection SUCCESS in 12m 35s
✔️ ansible-test-splitter SUCCESS in 4m 39s
✔️ integration-amazon.aws-1 SUCCESS in 7m 34s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7546cf6 into stable-6 Aug 31, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/39b19d83db072f1854adaac92e05f06abb63dd3e/pr-1716 branch August 31, 2023 09:57
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
sns: Add parameters for fifo topics

SUMMARY
Implements ansible-collections#1718. Adding message_group_id and message_deduplication_id to support publishing of messages to fifo topics.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns

Reviewed-by: Mark Chappell
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
sns: Add parameters for fifo topics

SUMMARY
Implements ansible-collections#1718. Adding message_group_id and message_deduplication_id to support publishing of messages to fifo topics.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns

Reviewed-by: Mark Chappell
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
sns: Add parameters for fifo topics

SUMMARY
Implements ansible-collections#1718. Adding message_group_id and message_deduplication_id to support publishing of messages to fifo topics.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community_review docs mergeit Merge the PR (SoftwareFactory) module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants