S3_bucket : Handle setting of permissions while acl is disabled #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GomathiselviS <[email protected]>
ansibullbot
added
bug
Contributor
jillr
approved these changes
Oct 13, 2022
Contributor
|
@GomathiselviS it would be good if you could add an integration test for this. |
Contributor
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Contributor
goneri
reviewed
Oct 17, 2022
| module.params['permission'] = object_acl | ||
| if not acl_disabled: | ||
| # only use valid object acls for the create_dirkey function | ||
| module.params['permission'] = object_acl |
Member
There was a problem hiding this comment.
I don't think it's a good idea to modify module.params like this. The variable is supposed to be read-only. It becomes really hard to track the origin of the change.
Contributor
Author
There was a problem hiding this comment.
@goneri I have not changed the code flow much from what existed. I am not modifying the module.params['permission'], but setting the value based on a condition.
Member
There was a problem hiding this comment.
Yes, I saw that the existing code is already doing that.
tremble
approved these changes
Oct 18, 2022
Contributor
tremble
left a comment
tremble
left a comment
There was a problem hiding this comment.
For the sake of getting this bug fixed, +1
I agree with @goneri about the danger of manipulating module.params, @GomathiselviS would you be able to clean that up separately?
goneri
approved these changes
Oct 18, 2022
Contributor
Author
@tremble @GomathiselviS I will open a separate PR to do the same. |
Contributor
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]>
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Sep 22, 2023
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7095617
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 6, 2023
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7095617
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 6, 2023
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7095617
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 6, 2023
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@7095617
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…collections#1168) iam_managed_policy - remove unused fail_on_delete parameter SUMMARY remove unused fail_on_delete parameter ISSUE TYPE Feature Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION ansible/ansible#63961 Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As per boto3 aws documentation
When ObjectOwnership is BucketOwnerEnforced - Access control lists (ACLs) are disabled and no longer affect permissions.Fixes #1137
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION