Deprecate state=list in ec2_vol #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionality is already available in ec2_vol_info Add missing return docs to ec2_vol_info
Contributor
Author
|
cc @tremble |
tremble
requested changes
Jul 16, 2020
Contributor
tremble
left a comment
tremble
left a comment
There was a problem hiding this comment.
1 minor nit, otherwise looks good. (Thought I'd already submitted PRs for deprecating state=list, must just have been the tests)
plugins/modules/ec2_vol_info.py
Outdated
| type: str | ||
| sample: "standard" | ||
| zone: | ||
| description: |
Contributor
There was a problem hiding this comment.
Suggested change
| description: | |
| description: The Availability Zone of the volume |
Not 100% on the whitespace here it's difficult to compare the 'real' and suggested indentation.
Contributor
Author
There was a problem hiding this comment.
Whitespace is totally wrong, thanks.
I think you did the deprecation for ec2_tag. I didn't find any others at least
tremble
requested changes
Jul 16, 2020
Co-authored-by: Mark Chappell <[email protected]>
tremble
approved these changes
Jul 16, 2020
Contributor
tremble
left a comment
tremble
left a comment
There was a problem hiding this comment.
Assuming the tests pass (don't see why they wouldn't given it's only docs changes since the last tests),
LGTM.
Contributor
Author
|
they would fail if I didn't bother to make the changelog valid yaml :) |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 25, 2022
ec2_vol - remove deprecated state=list SUMMARY Remove the deprecated state list from ec2_vol. This functionality has been moved to the ec2_vol_info module. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION See also: #108 Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
This wasn't added until 2.10; #67141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Deprecate state=list in ec2_vol
Functionality is already available in ec2_vol_info
Add missing return docs to ec2_vol_info
ISSUE TYPE
COMPONENT NAME
ec2_vol
ec2_vol_info