This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(menu-bar): close just nested menu when escape key is pressed #11934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Splaktar
suggested changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, sorry, looked closer at the tests and found a few concerns.
…stays with the parent menu when nested one is closed instead of closing all the menusFixes angular#11678
50004ae
to
5d1c941
Compare
Splaktar
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewseguin
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a11y
This issue is related to accessibility
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
P2: required
Issues that must be fixed.
pr: lgtm
This PR has been approved by the reviewer
pr: merge ready
This PR is ready for a caretaker to review
type: bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
focus stays with the parent menu when nested one is closed instead of closing all the menus
Fixes #11678
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
At the moment when the user presses escape key while the nested menu is open, it causes all the menus to become closed and the focus is lost.
Issue Number: #11678
What is the new behavior?
When the escape key is pressed, only the current nested menu is closed and the focus goes to the parent menu.
Does this PR introduce a breaking change?
Other information