Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

marosoft
Copy link
Contributor

@marosoft marosoft commented Jun 8, 2020

focus stays with the parent menu when nested one is closed instead of closing all the menus

Fixes #11678

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

At the moment when the user presses escape key while the nested menu is open, it causes all the menus to become closed and the focus is lost.

Issue Number: #11678

What is the new behavior?

When the escape key is pressed, only the current nested menu is closed and the focus goes to the parent menu.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 8, 2020
@Splaktar Splaktar self-assigned this Jun 8, 2020
@Splaktar Splaktar self-requested a review June 8, 2020 21:42
@Splaktar Splaktar added this to the 1.1.23 milestone Jun 8, 2020
@Splaktar Splaktar added a11y This issue is related to accessibility P2: required Issues that must be fixed. type: bug g3: sync in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Jun 9, 2020
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jun 9, 2020
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, sorry, looked closer at the tests and found a few concerns.

@Splaktar Splaktar added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jun 9, 2020
@Splaktar Splaktar changed the title fix(menuBar): close just nested menu when escape key is pressed fix(menu-bar): close just nested menu when escape key is pressed Jun 9, 2020
…stays with the parent menu when nested one is closed instead of closing all the menusFixes angular#11678
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Jun 12, 2020
@Splaktar Splaktar requested a review from andrewseguin June 12, 2020 18:46
@andrewseguin andrewseguin added the pr: lgtm This PR has been approved by the reviewer label Jun 15, 2020
@Splaktar Splaktar merged commit 98e259b into angular:master Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu-bar: Focus is lost after pressing "esc" while being in nested menu
4 participants