fix(github-actions): replace package-manager-cache with cache option in checkout-and-setup-node
#3151
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in checkout-and-setup-node In `actions/setup-node` version 6 `package-manager-cache` is only supported for npm. See: actions/setup-node#1374
devversion
reviewed
Oct 14, 2025
| node-version: ${{ inputs.node-version }} | ||
| cache-dependency-path: ${{ inputs.cache-dependency-path }} | ||
| package-manager-cache: ${{ inputs.disable-package-manager-cache != 'true' }} | ||
| cache: ${{ inputs.disable-package-manager-cache != 'true' && steps.packageManager.outputs.CACHE_MANAGER_VALUE || '' }} |
Member
There was a problem hiding this comment.
Is this supposed to be a boolean or a string of the package manager? Where do we set CACHE_MANAGER_VALUE to e.g. yarn?
Contributor
Author
There was a problem hiding this comment.
It's supposed to be a string.
CACHE_MANAGER_VALUE is set above, as part of this change.
Member
There was a problem hiding this comment.
I see, thanks. Isn't CACHE_MANAGER_VALUE only set for pnpm? is that expected because we only use pnpm at this point? If so, LGTM
devversion
approved these changes
Oct 14, 2025
| node-version: ${{ inputs.node-version }} | ||
| cache-dependency-path: ${{ inputs.cache-dependency-path }} | ||
| package-manager-cache: ${{ inputs.disable-package-manager-cache != 'true' }} | ||
| cache: ${{ inputs.disable-package-manager-cache != 'true' && steps.packageManager.outputs.CACHE_MANAGER_VALUE || '' }} |
Member
There was a problem hiding this comment.
I see, thanks. Isn't CACHE_MANAGER_VALUE only set for pnpm? is that expected because we only use pnpm at this point? If so, LGTM
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
actions/setup-nodeversion 6package-manager-cacheis only supported for npm.See: actions/setup-node#1374