Skip to content

fix(cdk-experimental/ui-patterns): focus list when using active desce… #31756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

fix(cdk-experimental/ui-patterns): focus list when using active desce… #31756

merged 2 commits into from
Aug 21, 2025

Conversation

wagnermaciel
Copy link
Contributor

…ndant

  • If a list is using active descendant to track focus, calling focus() on a list item should send focus to the parent list element.

@wagnermaciel
fix(cdk-experimental/ui-patterns): focus list when using active desce…
17d9cd4 
…ndant

* If a list is using active descendant to track focus, calling focus() on a list item should send focus to the parent list element.
@wagnermaciel wagnermaciel added the target: minor This PR is targeted for the next minor release label Aug 21, 2025
@wagnermaciel wagnermaciel requested a review from ok7sai August 21, 2025 15:53
@wagnermaciel wagnermaciel added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Aug 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Deployed dev-app for 42b17c2 to: https://ng-dev-previews-comp--pr-angular-components-31756-dev-uhb8idmt.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@wagnermaciel wagnermaciel marked this pull request as ready for review August 21, 2025 16:33
@wagnermaciel wagnermaciel requested a review from a team as a code owner August 21, 2025 16:33
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for a team August 21, 2025 16:33
@wagnermaciel wagnermaciel mentioned this pull request Aug 21, 2025
Merged
ok7sai
ok7sai approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@ok7sai ok7sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo styles seem off after the change

@wagnermaciel
Copy link
Contributor Author

Yeah, I switched the focus ring to stay on the list instead of the list item to indicate that the document.activeElement is the list. I'm second guessing this, though, as this seems like an implementation detail that shouldn't be visually indicated to users. What do you think?

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Aug 21, 2025
@wagnermaciel wagnermaciel removed the request for review from crisbeto August 21, 2025 18:26
@wagnermaciel wagnermaciel merged commit d2c3bb9 into angular:main Aug 21, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ok7sai ok7sai ok7sai approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagnermaciel @ok7sai