Skip to content

feat(material/chips): make ChipInput optional for MatChipGrid #31693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

feat(material/chips): make ChipInput optional for MatChipGrid #31693

merged 1 commit into from
Aug 21, 2025

Conversation

adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Aug 14, 2025 •
edited
Loading

Fixes b/370968899.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: material/chips labels Aug 14, 2025
@adolgachev adolgachev added action: review The PR is still awaiting reviews from at least one requested reviewer action: global presubmit The PR is in need of a google3 global presubmit Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase labels Aug 19, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

Deployed dev-app for ca082fb to: https://ng-dev-previews-comp--pr-angular-components-31693-dev-9f9h73uf.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

Deployed docs-preview for c10a150 to: https://ng-dev-previews-comp--pr-angular-components-31693-docs-r8ngq0fh.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev marked this pull request as ready for review August 19, 2025 00:57
@adolgachev adolgachev requested a review from a team as a code owner August 19, 2025 00:57
@adolgachev adolgachev requested review from crisbeto and ok7sai and removed request for a team August 19, 2025 00:57
@adolgachev adolgachev added requires: TGP This PR requires a passing TGP before merging is allowed and removed action: global presubmit The PR is in need of a google3 global presubmit labels Aug 19, 2025
crisbeto
crisbeto reviewed Aug 19, 2025
View reviewed changes
@adolgachev adolgachev requested review from mmalerba and removed request for ok7sai August 20, 2025 16:17
@adolgachev adolgachev removed the request for review from mmalerba August 21, 2025 17:38
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 21, 2025
@adolgachev adolgachev merged commit 29f0bb2 into angular:main Aug 21, 2025
22 of 25 checks passed
@adolgachev adolgachev deleted the chips-input branch August 21, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/chips detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adolgachev @crisbeto