chore: properly exit e2e tasks #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
chore/e2e-properly-exit
branch
from
3a8ec56 to
c6189b3
Compare
jelbourn
reviewed
Dec 2, 2016
tools/gulp/tasks/e2e.ts
Outdated
| const PROTRACTOR_CONFIG_PATH = path.join(PROJECT_ROOT, 'test/protractor.conf.js'); | ||
|
|
||
| /** Method to stop a running e2e web server, which may have not exited properly */ | ||
| let stopE2eServer: () => void = null; |
Member
There was a problem hiding this comment.
You could do
let stopE2eServer = () => {};And then just call stopE2eServer directly without cleanupTasks
Member
Author
There was a problem hiding this comment.
Sounds good. I had the cleanupTasks method because I thought that it would be good in the future to just have all cleanups at one place.
* Instead of manually exiting the process we should just ensure that everything is properly cleaned up and then gulp can take care of the exit codes. * If we have the `e2e:done` task at the end of the sequence it will be never called when an error occurred before
devversion
force-pushed
the
chore/e2e-properly-exit
branch
from
c6189b3 to
1939dca
Compare
Member
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually exiting the process we should just ensure that everything is properly cleaned up and then gulp can take care of the exit codes.
If we have the
e2e:donetask at the end of the sequence it will be never called when an error occurred before (will cause things like https://travis-ci.org/angular/material2/jobs/180782730)