Skip to content

fix(material-experimental): icon/fab missing states color #18403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

fix(material-experimental): icon/fab missing states color #18403

merged 1 commit into from
Feb 7, 2020

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Feb 5, 2020

Icon button and FAB were missing hover/focus/active state colors since they were missing the ripple target

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 5, 2020
@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Feb 5, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 5, 2020
crisbeto
crisbeto approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 5, 2020
@mmalerba mmalerba merged commit 9cfc66d into angular:master Feb 7, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 9, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewseguin @crisbeto @googlebot @mmalerba