build: remove unused angular bazel postinstall patch #18373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, when the framework repo updated their `rules_nodejs` version, a patch on the components was needed in order to make the `components-repo-unit-tests` job on framework green. Since this update PR already landed, and we updated to the Angular version that includes these changes, we can remove the patch.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Feb 5, 2020
In the past, when the framework repo updated their `rules_nodejs` version, a patch on the components was needed in order to make the `components-repo-unit-tests` job on framework green. Since this update PR already landed, and we updated to the Angular version that includes these changes, we can remove the patch.
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Feb 6, 2020
In the past, when the framework repo updated their `rules_nodejs` version, a patch on the components was needed in order to make the `components-repo-unit-tests` job on framework green. Since this update PR already landed, and we updated to the Angular version that includes these changes, we can remove the patch.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, when the framework repo updated their
rules_nodejsversion, a patch on the components was needed in order to make the
components-repo-unit-testsjob on framework green.Since this update PR already landed, and we updated to the Angular
version that includes these changes, we can remove the patch.