fix(material/input): input harness not matching matNativeControl

[devversion]

The input harness currently only matches [matInput], but does
not match [matNativeControl] usages. Since both names, resolve
to the same directive, we should ensure that the harness works for both
possible usages.

[mmalerba]

Do we want this to create harness instances for <select matNativeControl>? That might be unexpected from a user's point of view. If we do decide to intentionally include it we should make sure its included in the tests as well.

[devversion]

@mmalerba My thinking is that it wouldn't hurt to make the input harness work for these elements using matNativeControl. The harness exposes useful functionality for features of the directive.

I could also see having something like MatNativeControlHarness which simply has a different selector but extends MatInputHarness. Regarding tests, the PR includes a test for matNativeControl, or do you think of something else?

[mmalerba]

I mean a test with a <select> element. I think I'm ok with including it, but I'm curious if @jelbourn has an opinion

[devversion]

@mmalerba I looked more into it, and it looks like the scenario with select you brought up is slightly different than usual inputs:

• setValue will not work like for text inputs. We could add additional logic for native select elements.
• getPlaceholder currently relies on the host element .placeholder property. We could switch that to use the attribute.. though does it make sense to have such a method for native selects?

Also the more I think about it, it sounds wrong to have native select elements under MatInputHarness. The select is not necessarily an input (in terms of HTML elements).

[mmalerba]

Ok, that's what I was afraid of. In that case lets make the selector [matInput],input[matNativeControl]. We can make a separate harness for native select, or try to roll it into MatSelectHarness

[jelbourn]

LGTM

[devversion]

@mmalerba Addressed feedback. Can you please have another look?

[mmalerba]

Oh also textarea[matNativeControl], almost forgot about that one

[mmalerba]

LGTM other than the missing selector - add merge-ready when done

[devversion]

Fixed. Also added it to the tests.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}