Skip to content

Conversation

@crisbeto
Copy link
Member

The way the tree styles were set up initially means that the tree element can't cause its parent to overflow. Given that the tree can have a lot of nesting, this is bound to happen with deeper trees. These changes remove the default overflow: hidden since it doesn't seem to be doing much.

Fixes #18182.

The way the tree styles were set up initially means that the tree element can't cause its parent to overflow. Given that the tree can have a lot of nesting, this is bound to happen with deeper trees. These changes remove the default `overflow: hidden` since it doesn't seem to be doing much.

Fixes angular#18182.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 19, 2020
@crisbeto
Copy link
Member Author

Caretaker note: this has the potential to break screenshot tests. We should run a presubmit and figure out whether we still want to do it based on the results. If it's too breaky we can recommend to people to override our styles.

@crisbeto crisbeto added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Jan 19, 2020
@gubo
Copy link

gubo commented Jan 21, 2020

i could not affect overflow:hidden on the right element or at the right time, trying combinations of mat-tree, ng-deep, etc ... can you advise on how to affect this style in the above test project ?
in general, this is the main failure/shortcoming of angular material ... it is too hard / sometimes not possible, and there is no consistent way, to affect styles on material components ... especially when not using ng-deep nor ViewEncapsulation.NONE ...
is there a way to the material library could be made to accept styling in a consistent way ?
in the meantime, i am just dropping down to cdk-tree and not using mat-tree ...
thanks much :)

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 23, 2020
@jelbourn jelbourn merged commit c5923d6 into angular:master Jan 24, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
The way the tree styles were set up initially means that the tree element can't cause its parent to overflow. Given that the tree can have a lot of nesting, this is bound to happen with deeper trees. These changes remove the default `overflow: hidden` since it doesn't seem to be doing much.

Fixes angular#18182.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mat-tree will not horizontal scroll

4 participants