Skip to content

build: remove custom rxjs imports rule in favor of import-banlist rule #18157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

build: remove custom rxjs imports rule in favor of import-banlist rule #18157

merged 1 commit into from
Jan 16, 2020

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jan 12, 2020

No description provided.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 12, 2020
@devversion devversion requested a review from jelbourn as a code owner January 12, 2020 13:25
@devversion devversion requested a review from a team January 12, 2020 13:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 12, 2020
crisbeto
crisbeto approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 12, 2020
jelbourn
jelbourn approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like it needs a rebase now

@devversion devversion force-pushed the build/remove-custom-rxjs-import-rule branch from 0abc189 to fc698f3 Compare January 16, 2020 16:43
@devversion
Copy link
Member Author

devversion commented Jan 16, 2020

Rebased.

@jelbourn jelbourn merged commit 581d1f2 into angular:master Jan 16, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
build: remove custom rxjs imports rule in favor of import-banlist rule (
67bbde3 
angular#18157)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 16, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devversion @jelbourn @crisbeto @googlebot @andrewseguin