Skip to content

fix(material-experimental/mdc-tabs): incorrect tab text color in dark theme #18068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2020
Merged

fix(material-experimental/mdc-tabs): incorrect tab text color in dark theme #18068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/material-experimental/mdc-tabs/_mdc-tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@
// variables to their original values and prevent unintended side effects from using this mixin.
$orig-mdc-tab-text-label-color-active: $mdc-tab-text-label-color-active;
$orig-mdc-tab-icon-color-active: $mdc-tab-icon-color-active;
$orig-mdc-tab-text-label-color-default: $mdc-tab-text-label-color-default;

@include mat-using-mdc-theme($theme) {
// This value is the same as MDC's default, but MDC defines it once inside
// a variables file which means that we can't override it with our own palette.
$mdc-tab-text-label-color-default:
rgba(mdc-theme-prop-value(on-surface), $mdc-tab-text-label-opacity) !global;

@include _mat-mdc-tabs-palette-styles($mdc-tab-text-label-color-active);

.mat-mdc-tab-group, .mat-mdc-tab-nav-bar {
Expand Down Expand Up @@ -49,6 +55,7 @@
// Restore original values of MDC global variables.
$mdc-tab-text-label-color-active: $orig-mdc-tab-text-label-color-active !global;
$mdc-tab-icon-color-active: $orig-mdc-tab-icon-color-active !global;
$mdc-tab-text-label-color-default: $orig-mdc-tab-text-label-color-default !global;
}

@mixin _mat-mdc-tabs-background($background-color, $foreground-color) {
Expand Down