refactor: fix various typescript 3.7 compilation errors #18060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
Fixes a few places which will start erroring when we upgrade to TypeScript 3.7. This should make it easier to upgrade eventually.
crisbeto
force-pushed
the
ts-3.7-fixes
branch
from
36ba828 to
5a7e704
Compare
devversion
approved these changes
Dec 31, 2019
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
Fixes a few places which will start erroring when we upgrade to TypeScript 3.7. This should make it easier to upgrade eventually.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few places which will start erroring when we upgrade to TypeScript 3.7. This should make it easier to upgrade eventually.
Note: marking as merge safe, because these are only changes to internal types and test files.