Skip to content

Conversation

@rluvaton
Copy link
Contributor

Fix part of #13195 (Size not enforced)

@rluvaton rluvaton requested a review from jelbourn as a code owner December 22, 2019 11:05
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Dec 22, 2019
@rluvaton
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Dec 22, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the commit message to something like docs(form-field): enforce input length in custom form field example?

docs(form-field): enforce input length in the custom form field example and remove the size as @crisbeto suggested [here](angular#18028 (comment))
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 1, 2020
@mmalerba mmalerba merged commit 0429dfc into angular:master Jan 6, 2020
@rluvaton rluvaton deleted the patch-1 branch January 7, 2020 04:43
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
* Fix part of angular#13195 (Size not enforced)

Fix part of angular#13195 (Size not enforced)

* docs(form-field): enforce input length in the custom form field example

docs(form-field): enforce input length in the custom form field example and remove the size as @crisbeto suggested [here](angular#18028 (comment))
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants