-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix part of #13195 (Size not enforced) #18028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix part of angular#13195 (Size not enforced)
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
crisbeto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change the commit message to something like docs(form-field): enforce input length in custom form field example?
docs(form-field): enforce input length in the custom form field example and remove the size as @crisbeto suggested [here](angular#18028 (comment))
crisbeto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix part of angular#13195 (Size not enforced) Fix part of angular#13195 (Size not enforced) * docs(form-field): enforce input length in the custom form field example docs(form-field): enforce input length in the custom form field example and remove the size as @crisbeto suggested [here](angular#18028 (comment))
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix part of #13195 (Size not enforced)