Skip to content

feat(material/grid-list): add test harness #18001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2019
Merged

feat(material/grid-list): add test harness #18001

merged 1 commit into from
Dec 29, 2019

Conversation

@devversion
Copy link
Member

@devversion devversion commented Dec 18, 2019

  • Adds a test harness for grid-list

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 18, 2019
devversion
devversion commented Dec 18, 2019
View reviewed changes
@devversion devversion added the target: patch This PR is targeted for the next patch release label Dec 18, 2019
@devversion devversion force-pushed the feat/test-harness-grid-list branch from 8ebc749 to e323169 Compare December 18, 2019 20:27
@devversion devversion marked this pull request as ready for review December 18, 2019 20:28
@devversion devversion requested a review from jelbourn as a code owner December 18, 2019 20:28
jelbourn
jelbourn approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 19, 2019
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Dec 19, 2019
@mmalerba mmalerba merged commit 5e9ca28 into angular:master Dec 29, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 29, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba left review comments

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @mmalerba @googlebot