feat(drag-drop): add injection token for configuring the input defaults #17970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
17921/drag-drop-defaults
branch
from
a6054c4 to
2874689
Compare
jelbourn
added
blocked
mmalerba
removed
the
blocked
crisbeto
force-pushed
the
17921/drag-drop-defaults
branch
from
2874689 to
3737773
Compare
jelbourn
reviewed
Jan 14, 2020
| * Injection token that can be used to configure the | ||
| * behavior of the drag&drop-related components. | ||
| */ | ||
| export const CDK_DRAG_CONFIG = new InjectionToken<DragDropConfig>('CDK_DRAG_CONFIG'); |
Member
There was a problem hiding this comment.
CDK_DRAG_DEFAULT_OPTIONS for consistency?
Member
Author
There was a problem hiding this comment.
This would be a breaking change since CDK_DRAG_CONFIG is already in master.
crisbeto
force-pushed
the
17921/drag-drop-defaults
branch
from
3737773 to
9e4b79a
Compare
Member
|
@crisbeto passes presubmit, just needs rebase |
Adds an injection token that allows consumers to change the defaults of the various options in the `drag-drop` module. Also moves some repeated inline types into shared ones. Fixes angular#17921.
crisbeto
force-pushed
the
17921/drag-drop-defaults
branch
from
9e4b79a to
18400b6
Compare
Member
Author
|
Rebased. |
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…ts (angular#17970) Adds an injection token that allows consumers to change the defaults of the various options in the `drag-drop` module. Also moves some repeated inline types into shared ones. Fixes angular#17921.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an injection token that allows consumers to change the defaults of the various options in the
drag-dropmodule. Also moves some repeated inline types into shared ones.Fixes #17921.