Skip to content

build: set incompatible_strict_action_env flag to allow caching #17893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

build: set incompatible_strict_action_env flag to allow caching #17893

merged 1 commit into from
Dec 10, 2019

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Dec 6, 2019

The incompatible_strict_action_env flag is needed to so that the
bazel cache is not invalidated when running bazel via yarn bazel.

@josephperrott
build: set incompatible_strict_action_env flag to allow caching
ad0fa27 
The incompatible_strict_action_env flag is needed to so that the
bazel cache is not invalidated when running bazel via `yarn bazel`.
@josephperrott josephperrott added pr: merge safe target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release labels Dec 6, 2019
@josephperrott josephperrott requested review from a team and jelbourn as code owners December 6, 2019 19:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2019
devversion
devversion approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome find! 💯 Maybe this also speeds up ibazel somehow. We'll see!

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 6, 2019
@josephperrott josephperrott added the P2 The issue is important to a large percentage of users, with a workaround label Dec 9, 2019
@mmalerba mmalerba merged commit 2a8d21d into angular:master Dec 10, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 10, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2020
@josephperrott josephperrott deleted the strict-act-env branch March 20, 2020 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephperrott @devversion @googlebot @mmalerba