fix(button-toggle): Provide better docs for ngModel in wqbutton-toggle-group multiple
#1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
tinayuangao
added
pr: needs review
and removed
cla: yes
jelbourn
reviewed
Nov 7, 2016
src/lib/button-toggle/README.md
Outdated
| `md-button-toggle` can be used in a multiple selection group when surrounded by | ||
| `md-button-toggle-group multiple`. This styles all buttons within the group to appear as a single | ||
| group of button toggles. | ||
| group of button toggles. Now `ngModel` binding is not supported in multiple selection mode. |
Member
There was a problem hiding this comment.
I'd phrase it as
This component does not yet support `NgModel` when using `multiple` mode.
tinayuangao
force-pushed
the
button-toggle-docs
branch
from
0099608 to
40751a7
Compare
googlebot
added
the
cla: yes
Member
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
rolandjitsu
pushed a commit
to rolandjitsu/material2
that referenced
this pull request
Nov 10, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1039.
R: @jelbourn