Skip to content

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 8, 2019

No description provided.

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Oct 8, 2019
@mmalerba mmalerba requested a review from a team as a code owner October 8, 2019 22:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 8, 2019
CHANGELOG.md Outdated
| bug fix | **select:** highlighted option not updated if value is reset while closed ([#17213](https://github.com/angular/components/issues/17213)) ([d996abd](https://github.com/angular/components/commit/d996abd)), closes [#17212](https://github.com/angular/components/issues/17212) |
| bug fix | **stepper:** unable to skip step if completed value is overwritten ([#15403](https://github.com/angular/components/issues/15403)) ([9f497a0](https://github.com/angular/components/commit/9f497a0)), closes [#15310](https://github.com/angular/components/issues/15310) |
| bug fix | **tabs:** avoid Ivy template type checking errors in tab link ([#17282](https://github.com/angular/components/issues/17282)) ([cd11ae5](https://github.com/angular/components/commit/cd11ae5)), closes [#17228](https://github.com/angular/components/issues/17228) |
| bug fix | **tabs:** avoid template type checking errors with Ivy ([#17228](https://github.com/angular/components/issues/17228)) ([1bfa1ea](https://github.com/angular/components/commit/1bfa1ea)), closes [#17022](https://github.com/angular/components/issues/17022) [#17121](https://github.com/angular/components/issues/17121) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrectly pulling in the "Closes/Fixes" PR. It does reference #17022 but it does not fix it.

This is a problem I noticed in previous runs of the CHANGELOG, not sure the logic behind it. @devversion do you know what might be causing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. interesting. we should create an issue for it (to track it)

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 8, 2019
@mmalerba mmalerba merged commit a1f59b2 into angular:master Oct 9, 2019
@mmalerba mmalerba deleted the changelog-master branch October 9, 2019 15:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants