feat: move clipboard module into cdk #17272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P1
googlebot
added
the
cla: yes
crisbeto
commented
Oct 2, 2019
crisbeto
force-pushed
the
clipboard-module
branch
3 times, most recently
from
0389035 to
6510231
Compare
crisbeto
force-pushed
the
clipboard-module
branch
from
6510231 to
05113af
Compare
jelbourn
reviewed
Oct 2, 2019
src/material-examples/cdk/clipboard/cdk-clipboard-overview/cdk-clipboard-overview-example.ts
Outdated
Show resolved
Hide resolved
Moves the `clipboard` module into CDK stable, sets up the API goldens, adjusts some APIs to be more consistent and sets up a live example.
crisbeto
force-pushed
the
clipboard-module
branch
from
05113af to
e444cba
Compare
Member
Author
|
I've addressed the feedback @jelbourn. |
jelbourn
approved these changes
Oct 3, 2019
| styleUrls: ['cdk-clipboard-overview-example.css'], | ||
| }) | ||
| export class CdkClipboardOverviewExample { | ||
| value = `Did you ever hear the tragedy of Darth Plagueis The Wise? I thought not. It's not ` + |
Member
There was a problem hiding this comment.
A surprise for sure, but a welcome one.
jelbourn
added
pr: lgtm
action: merge
Member
|
Caretaker note: this will require updating build rules internally |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
clipboardmodule into CDK stable, sets up the API goldens, adjusts some APIs to be more consistent and sets up a live example.