fix(drag-drop): handle the element going out of the boundary after a viewport resize #16874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15749/drag-drop-boundary-resize
branch
from
6e79fc0 to
030d1b8
Compare
Member
|
@crisbeto passes presubmit, just needs rebase |
…viewport resize Adds some logic to ensure that an element inside a boundary is contained within it after the viewport is resized and the boundary may have changed size. Fixes angular#16536.
crisbeto
force-pushed
the
15749/drag-drop-boundary-resize
branch
from
030d1b8 to
076e451
Compare
Member
Author
|
Rebased @jelbourn. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some logic to ensure that an element inside a boundary is contained within it after the viewport is resized and the boundary may have changed size.
Fixes #16536.