Skip to content

refactor(focus-monitor): adapt demo examples for Ivy #15475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2019
Merged

refactor(focus-monitor): adapt demo examples for Ivy #15475

merged 1 commit into from
Mar 14, 2019

Conversation

@marclaval
Copy link
Contributor

@marclaval marclaval commented Mar 14, 2019

This fixes FW-1163

@marclaval marclaval requested a review from jelbourn as a code owner March 14, 2019 09:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2019
@marclaval marclaval mentioned this pull request Mar 14, 2019
Merged
@marclaval marclaval force-pushed the fixFocusOriginExample branch from b2e3fb9 to 4abe814 Compare March 14, 2019 13:08
crisbeto
crisbeto approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 14, 2019
@ngbot
Copy link

ngbot bot commented Mar 14, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
Copy link
Member

crisbeto commented Mar 14, 2019

The failing CI check is unrelated and will be fixed by #15479.

@mmalerba mmalerba merged commit 747e455 into angular:master Mar 14, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
@marclaval @mmalerba
refactor(focus-monitor): adapt demo examples for Ivy (#15475)
100a04c
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@marclaval
refactor(focus-monitor): adapt demo examples for Ivy (angular#15475)
c6a51e7
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marclaval @crisbeto @googlebot @mmalerba