Skip to content

test(slide-toggle): adding missing detectChanges() and tick() #15309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2019
Merged

test(slide-toggle): adding missing detectChanges() and tick() #15309

merged 1 commit into from
Feb 26, 2019

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Feb 26, 2019

This makes a test pass both with ivy and ViewEngine

@jelbourn
test(slide-toggle): adding missing detectChanges() and tick()
5d907d2 
This makes a test pass both with ivy and ViewEngine
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Feb 26, 2019
@jelbourn jelbourn requested review from crisbeto and kara February 26, 2019 02:45
@jelbourn jelbourn requested a review from devversion as a code owner February 26, 2019 02:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 26, 2019
crisbeto
crisbeto approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should remember to cherry-pick this into the Ivy branch.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 26, 2019
@jelbourn jelbourn merged commit 740a2ee into angular:master Feb 26, 2019
jelbourn added a commit that referenced this pull request Feb 26, 2019
@jelbourn
test(slide-toggle): adding missing detectChanges() and tick() (#15309)
669d586 
This makes a test pass both with ivy and ViewEngine
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@kara kara Awaiting requested review from kara

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jelbourn @crisbeto @devversion @googlebot