Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

Prior to this change, watching of an npm link of a library in another workspace when preserveSymlinks was set to true was not being picked up as node_modules files were always ignored.

Closes #25753

…ibrary from another workspace when `preserveSymlinks` is `true`

Prior to this change, watching of an `npm link` of a library in another workspace when `preserveSymlinks` was set to `true` was not being picked up as `node_modules` files were always ignored.

Closes angular#25753
@alan-agius4 alan-agius4 requested a review from clydin December 11, 2023 09:23
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 11, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 11, 2023
@alan-agius4 alan-agius4 merged commit 2909daf into angular:main Dec 11, 2023
@alan-agius4 alan-agius4 deleted the link-lib-preserve branch December 11, 2023 14:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

esbuild doesn't watch for local library changes while running dev server (cli-cache-enabled=false,preserveSymlinks=true)

2 participants