Don't double-transition on child states with no URLs #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ksperling If I can get a review of this, it should be the last change needed to finish implementing and testing |
|
Good catch! See my comment in the code regarding the particular check though... I think we need to check for |
|
@ksperling Yeah good call. I've updated the patch. Go ahead and merge if it looks good. |
ksperling
added a commit
that referenced
this pull request
Jun 19, 2013
Don't double-transition on child states with no URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this issue while trying to finish up the
ui-srefdirective.Basically, if a state has a URL, but a child state does not, it is impossible to transition to the child state, because the change in location will immediately trigger a second state transition to the parent. This fixes the issue by checking to see if the current state is a child of a state being targeted for transition based on a URL match.
Also fixes a typo in a test name. :-)